viz: Defer BeginFrame throttling everywhere.

The initial change [1] restricted the delay in BeginFrame throttling to
SurfaceControl to allow the change to be merged to M76. But this
throttling policy is better in general so enable it everywhere.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1675464
R=ericrk@chromium.org

Bug: 973703
Change-Id: Ia26c23786b1e827fa22126c06a474fca65d20280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684216
Auto-Submit: Khushal <khushalsagar@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673856}

components/viz/common/frame_sinks/begin_frame_source.cc

@@ -140,12 +140,9 @@ bool BeginFrameSource::RequestCallbackOnGpuAvailable() {
 
   switch (gpu_busy_response_state_) {
     case GpuBusyThrottlingState::kIdle:
-      if (allow_one_begin_frame_after_gpu_busy_) {
         gpu_busy_response_state_ =
             GpuBusyThrottlingState::kOneBeginFrameAfterBusySent;
         return false;
-      }
-      FALLTHROUGH;
     case GpuBusyThrottlingState::kOneBeginFrameAfterBusySent:
       gpu_busy_response_state_ = GpuBusyThrottlingState::kThrottled;
       return true;

components/viz/common/frame_sinks/begin_frame_source.h

@@ -159,11 +159,6 @@ class VIZ_COMMON_EXPORT BeginFrameSource {
 
   virtual void AsValueInto(base::trace_event::TracedValue* state) const;
 
-  void AllowOneBeginFrameAfterGpuBusy() {
-    DCHECK(!is_gpu_busy_);
-    allow_one_begin_frame_after_gpu_busy_ = true;
-  }
-
  protected:
   // Returns whether begin-frames to clients should be withheld (because the gpu
   // is still busy, for example). If this returns true, then OnGpuNoLongerBusy()
@@ -197,8 +192,6 @@ class VIZ_COMMON_EXPORT BeginFrameSource {
   GpuBusyThrottlingState gpu_busy_response_state_ =
       GpuBusyThrottlingState::kIdle;
 
-  bool allow_one_begin_frame_after_gpu_busy_ = false;
-
   DISALLOW_COPY_AND_ASSIGN(BeginFrameSource);
 };
 

components/viz/service/display/display_scheduler_unittest.cc

@@ -796,8 +796,6 @@ TEST_F(DisplaySchedulerTest, SetNeedsOneBeginFrame) {
 }
 
 TEST_F(DisplaySchedulerTest, GpuBusyNotifications) {
-  fake_begin_frame_source_.AllowOneBeginFrameAfterGpuBusy();
-
   SurfaceId root_surface_id(
       kArbitraryFrameSinkId,
       LocalSurfaceId(1, base::UnguessableToken::Create()));

components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc

@@ -78,10 +78,6 @@ RootCompositorFrameSinkImpl::Create(
     external_begin_frame_source =
         std::make_unique<ExternalBeginFrameSourceAndroid>(restart_id,
                                                           params->refresh_rate);
-    if (output_surface->context_provider() &&
-        output_surface->context_provider()->ContextCapabilities().surfaceless) {
-      external_begin_frame_source->AllowOneBeginFrameAfterGpuBusy();
-    }
 #else
     if (params->disable_frame_rate_limit) {
       synthetic_begin_frame_source =