Commit 86faed3c authored by Martin Kreichgauer's avatar Martin Kreichgauer Committed by Commit Bot

webauth: clean up AuthenticatorCommon::SignalFailureToRequestDelegate()

This removes a giant switch on FidoReturnCode that's better handled
higher up the stack. Also resolve a stale TODO while we're at it.

Bug: 876109
Change-Id: I84bd8aa0a0c73e0a59dad7a673f041ded6019e4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764760Reviewed-by: default avatarAdam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691737}
parent c7844227
......@@ -167,12 +167,13 @@ class CONTENT_EXPORT AuthenticatorCommon {
// account from the options.
void OnAccountSelected(device::AuthenticatorGetAssertionResponse response);
// Decides whether or not UI is present that needs to block on user
// acknowledgement before returning the error, and handles the error
// appropriately.
// Signals to the request delegate that the request has failed for |reason|.
// The request delegate decides whether to present the user with a visual
// error before the request is finally resolved with |status|.
void SignalFailureToRequestDelegate(
const ::device::FidoAuthenticator* authenticator,
AuthenticatorRequestClientDelegate::InterestingFailureReason reason);
AuthenticatorRequestClientDelegate::InterestingFailureReason reason,
blink::mojom::AuthenticatorStatus status);
void InvokeCallbackAndCleanup(
blink::mojom::Authenticator::MakeCredentialCallback callback,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment