Commit 8730008c authored by Ruslan Burakov's avatar Ruslan Burakov Committed by Commit Bot

add jitter-buffer-fast-accelerate for webrtc configuration under origin trial

Experiment discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hE2B1iItPDk

Bug: 908272
Change-Id: I97a5d26996469d33b75afa4babf40e54eb830e6a
Reviewed-on: https://chromium-review.googlesource.com/c/1350174
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611043}
parent 552f1f3e
...@@ -49,5 +49,6 @@ dictionary RTCConfiguration { ...@@ -49,5 +49,6 @@ dictionary RTCConfiguration {
// Nonstandard, added for Unified Plan migration // Nonstandard, added for Unified Plan migration
[RuntimeEnabled=RTCUnifiedPlan] SdpSemantics sdpSemantics; [RuntimeEnabled=RTCUnifiedPlan] SdpSemantics sdpSemantics;
[OriginTrialEnabled=RtcAudioJitterBufferMaxPackets] long rtcAudioJitterBufferMaxPackets; [OriginTrialEnabled=RtcAudioJitterBufferMaxPackets] long rtcAudioJitterBufferMaxPackets;
[OriginTrialEnabled=RtcAudioJitterBufferMaxPackets] boolean rtcAudioJitterBufferFastAccelerate;
}; };
...@@ -420,6 +420,12 @@ webrtc::PeerConnectionInterface::RTCConfiguration ParseConfiguration( ...@@ -420,6 +420,12 @@ webrtc::PeerConnectionInterface::RTCConfiguration ParseConfiguration(
static_cast<int>(configuration->rtcAudioJitterBufferMaxPackets()); static_cast<int>(configuration->rtcAudioJitterBufferMaxPackets());
} }
if (configuration->hasRtcAudioJitterBufferFastAccelerate()) {
UseCounter::Count(context, WebFeature::kRTCMaxAudioBufferSize);
web_configuration.audio_jitter_buffer_fast_accelerate =
configuration->hasRtcAudioJitterBufferFastAccelerate();
}
return web_configuration; return web_configuration;
} }
...@@ -1255,6 +1261,8 @@ RTCConfiguration* RTCPeerConnection::getConfiguration( ...@@ -1255,6 +1261,8 @@ RTCConfiguration* RTCPeerConnection::getConfiguration(
webrtc_configuration.audio_jitter_buffer_max_packets; webrtc_configuration.audio_jitter_buffer_max_packets;
result->setRtcAudioJitterBufferMaxPackets( result->setRtcAudioJitterBufferMaxPackets(
static_cast<int32_t>(audio_jitter_buffer_max_packets)); static_cast<int32_t>(audio_jitter_buffer_max_packets));
result->setRtcAudioJitterBufferFastAccelerate(
webrtc_configuration.audio_jitter_buffer_fast_accelerate);
} }
return result; return result;
......
...@@ -19,4 +19,15 @@ test(t => { ...@@ -19,4 +19,15 @@ test(t => {
); );
}, 'rtcAudioJitterBufferMaxPackets property in Origin-Trial enabled document.'); }, 'rtcAudioJitterBufferMaxPackets property in Origin-Trial enabled document.');
test(t => {
var peerconnection = new RTCPeerConnection({
rtcAudioJitterBufferFastAccelerate: true
});
var configuration = peerconnection.getConfiguration();
assert_true(
configuration.rtcAudioJitterBufferFastAccelerate,
'rtcAudioJitterBufferFastAccelerate equals passed values'
);
}, 'rtcAudioJitterBufferFastAccelerate property in Origin-Trial enabled document.');
</script> </script>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment