Commit 873999af authored by Caroline Rising's avatar Caroline Rising Committed by Chromium LUCI CQ

Read later: add missing aria labels to reading list items.

Bug: 1109316
Change-Id: I484e3e5519b7a483cdb2a3ae553529534d1265ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626006
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: default avatarConnie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843675}
parent e1a47782
......@@ -86,7 +86,8 @@
</div>
<template id="ureadItemsList" is="dom-repeat" items="[[unreadItems_]]">
<read-later-item data-url$="[[item.url.url]]" on-focus="onItemFocus_"
class="mwb-list-item" data="[[item]]" tabindex="0">
aria-label="[[ariaLabel_(item)]]" class="mwb-list-item"
data="[[item]]" tabindex="0">
</read-later-item>
</template>
<div hidden="[[!readItems_.length]]" class="sub-heading">
......@@ -94,7 +95,8 @@
</div>
<template id="readItemsList" is="dom-repeat" items="[[readItems_]]">
<read-later-item data-url$="[[item.url.url]]" on-focus="onItemFocus_"
class="mwb-list-item" data="[[item]]" tabindex="0">
aria-label="[[ariaLabel_(item)]]" class="mwb-list-item"
data="[[item]]" tabindex="0">
</read-later-item>
</template>
</iron-selector>
......
......@@ -83,6 +83,16 @@ export class ReadLaterAppElement extends PolymerElement {
});
}
/**
* @param {!readLater.mojom.ReadLaterEntry} item
* @return {string}
* @private
*/
ariaLabel_(item) {
return `${item.title} - ${item.displayUrl} - ${
item.displayTimeSinceUpdate}`;
}
/**
* @return {boolean}
* @private
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment