Skip to content

GitLab

T
tangled
Commit 874f0007 authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot
Browse files
Options

Fix fast/text/transform-text-first-line.html not to rely on a known issue 

The new approach to apply the 'text-transform' property to
::first-line pseudo element[1] has a known issue that, since
it transforms at paint time, line breaking is measured
against non-transformed text.

The test fast/text/transform-text-first-line.html relies on
line breaking is measured against small letters, but this
issue does not exist in LayoutNG.

This patch fixes the test by using Ahem. Because Ahem has
different glyph but the same width for small letter 'p',
it can test which letters are capitalized without line
breaking being affected by the issue.

[1] https://chromium-review.googlesource.com/603855

TBR=eae@chromium.org

Bug: 129669, 644733, 636993
Change-Id: Ie0a14652c43d4b863ea0fd9bf40d8ab17f39d0ea
Reviewed-on: https://chromium-review.googlesource.com/1051067Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557129}
parent e885c34b
Hide whitespace changes
Inline Side-by-side
Showing with 11 additions and 6 deletions
third_party/WebKit/LayoutTests/fast/text/transform-text-first-line-expected.html
View file @ 874f0007
<!DOCTYPE html> <!DOCTYPE html>
<style> <style>
p {
font-family: Ahem;
line-height: 2;
}
</style> </style>
<p>THIS IS A SOMEWHAT<br>long HTML<br>paragraph.</p> <p>PPPP PP P PPPPPPPP<br>pppp PPPP<br>pppppppppppp</p>
<script>
third_party/WebKit/LayoutTests/fast/text/transform-text-first-line.html
View file @ 874f0007
<!DOCTYPE html> <!DOCTYPE html>
<style> <style>
p { width: 140px } p {
font-family: Ahem;
line-height: 2;
width: 20ch;
}
p::first-line { text-transform: uppercase; } p::first-line { text-transform: uppercase; }
</style> </style>
<p>This is a somewhat long HTML paragraph.</p> <p>Pppp pp p pppppppp pppp PPPP pppppppppppp</p>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment