Commit 87608ddf authored by Dominic Battre's avatar Dominic Battre Committed by Commit Bot

Disable flaky BookmarkPersonalizedSigninPromoTest

TBR=twellington@chromium.org,bsazonov@chromium.org

Bug: 789531
Change-Id: I7ca028d21988508247c3798d8ce5fc1c5eba91f6
Reviewed-on: https://chromium-review.googlesource.com/1219613
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Reviewed-by: default avatarBoris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590329}
parent ccb8f054
...@@ -31,6 +31,7 @@ import org.junit.runner.RunWith; ...@@ -31,6 +31,7 @@ import org.junit.runner.RunWith;
import org.chromium.base.ThreadUtils; import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisableIf; import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.RetryOnFailure; import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity; import org.chromium.chrome.browser.ChromeActivity;
...@@ -75,6 +76,7 @@ public class BookmarkPersonalizedSigninPromoTest { ...@@ -75,6 +76,7 @@ public class BookmarkPersonalizedSigninPromoTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "crbug.com/789531")
public void testManualDismissPromo() throws Exception { public void testManualDismissPromo() throws Exception {
openBookmarkManager(); openBookmarkManager();
onView(withId(R.id.signin_promo_view_container)).check(matches(isDisplayed())); onView(withId(R.id.signin_promo_view_container)).check(matches(isDisplayed()));
...@@ -82,10 +84,10 @@ public class BookmarkPersonalizedSigninPromoTest { ...@@ -82,10 +84,10 @@ public class BookmarkPersonalizedSigninPromoTest {
onView(withId(R.id.signin_promo_view_container)).check(doesNotExist()); onView(withId(R.id.signin_promo_view_container)).check(doesNotExist());
} }
// If this starts flaking again, disable the test. See crbug.com/789531.
@Test @Test
@LargeTest @LargeTest
@DisableIf.Device(type = {UiDisableIf.TABLET}) // https://crbug.com/776405. @DisableIf.Device(type = {UiDisableIf.TABLET}) // https://crbug.com/776405.
@DisabledTest(message = "crbug.com/789531")
public void testAutoDismissPromo() throws Exception { public void testAutoDismissPromo() throws Exception {
int impressionCap = SigninPromoController.getMaxImpressionsBookmarksForTests(); int impressionCap = SigninPromoController.getMaxImpressionsBookmarksForTests();
for (int impression = 0; impression < impressionCap; impression++) { for (int impression = 0; impression < impressionCap; impression++) {
...@@ -99,6 +101,7 @@ public class BookmarkPersonalizedSigninPromoTest { ...@@ -99,6 +101,7 @@ public class BookmarkPersonalizedSigninPromoTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "crbug.com/789531")
public void testSigninButtonDefaultAccount() throws Exception { public void testSigninButtonDefaultAccount() throws Exception {
addTestAccount(); addTestAccount();
openBookmarkManager(); openBookmarkManager();
...@@ -120,6 +123,7 @@ public class BookmarkPersonalizedSigninPromoTest { ...@@ -120,6 +123,7 @@ public class BookmarkPersonalizedSigninPromoTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "crbug.com/789531")
public void testSigninButtonNotDefaultAccount() throws Exception { public void testSigninButtonNotDefaultAccount() throws Exception {
addTestAccount(); addTestAccount();
openBookmarkManager(); openBookmarkManager();
...@@ -140,6 +144,7 @@ public class BookmarkPersonalizedSigninPromoTest { ...@@ -140,6 +144,7 @@ public class BookmarkPersonalizedSigninPromoTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "crbug.com/789531")
public void testSigninButtonNewAccount() throws Exception { public void testSigninButtonNewAccount() throws Exception {
openBookmarkManager(); openBookmarkManager();
onView(withId(R.id.signin_promo_view_container)).check(matches(isDisplayed())); onView(withId(R.id.signin_promo_view_container)).check(matches(isDisplayed()));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment