Commit 8786f4c5 authored by Andrey Kraynov's avatar Andrey Kraynov Committed by Commit Bot

Remove FrameSelection.h include from Editor.h header

<FrameSelection.h> header was needed only for RevealSelectionAfterEditingOperation
function parameter. But it seems that all call sites of this private function
didn't specify the second parameter and always used default value.

Bug: 
Change-Id: I9c4a40c36287c9ccc9a908554df8c106283d1430
Reviewed-on: https://chromium-review.googlesource.com/667377Reviewed-by: default avatarNate Chapin <japhet@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Reviewed-by: default avatarXiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#504786}
parent c2e46640
......@@ -38,6 +38,7 @@
#include "core/editing/EditingStrategy.h"
#include "core/editing/Editor.h"
#include "core/editing/EphemeralRange.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/PlainTextRange.h"
#include "core/editing/PositionIterator.h"
#include "core/editing/PositionWithAffinity.h"
......
......@@ -47,6 +47,7 @@
#include "core/editing/EditingTriState.h"
#include "core/editing/EditingUtilities.h"
#include "core/editing/EphemeralRange.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/InputMethodController.h"
#include "core/editing/RenderedPosition.h"
#include "core/editing/SelectionTemplate.h"
......@@ -1396,13 +1397,12 @@ void Editor::SetBaseWritingDirection(WritingDirection direction) {
}
void Editor::RevealSelectionAfterEditingOperation(
const ScrollAlignment& alignment,
RevealExtentOption reveal_extent_option) {
const ScrollAlignment& alignment) {
if (prevent_reveal_selection_)
return;
if (!GetFrameSelection().IsAvailable())
return;
GetFrameSelection().RevealSelection(alignment, reveal_extent_option);
GetFrameSelection().RevealSelection(alignment, kDoNotRevealExtent);
}
// TODO(yosin): We should move |Transpose()| into |ExecuteTranspose()| in
......
......@@ -33,10 +33,10 @@
#include "core/editing/EditingStyle.h"
#include "core/editing/FindOptions.h"
#include "core/editing/Forward.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/VisibleSelection.h"
#include "core/editing/WritingDirection.h"
#include "core/events/InputEvent.h"
#include "core/layout/ScrollAlignment.h"
#include "platform/PasteMode.h"
#include "platform/heap/Handle.h"
......@@ -51,6 +51,7 @@ class LocalFrame;
class HitTestResult;
class KillRing;
class Pasteboard;
class SetSelectionOptions;
class SpellChecker;
class StylePropertySet;
class TextEvent;
......@@ -350,8 +351,7 @@ class CORE_EXPORT Editor final : public GarbageCollectedFinalized<Editor> {
PasteMode = kAllMimeTypes);
void RevealSelectionAfterEditingOperation(
const ScrollAlignment& = ScrollAlignment::kAlignCenterIfNeeded,
RevealExtentOption = kDoNotRevealExtent);
const ScrollAlignment& = ScrollAlignment::kAlignCenterIfNeeded);
void ChangeSelectionAfterCommand(const SelectionInDOMTree&,
const SetSelectionOptions&);
......
......@@ -27,6 +27,7 @@
#include "core/editing/Editor.h"
#include "core/editing/EditingUtilities.h"
#include "core/editing/FrameSelection.h"
#include "core/events/KeyboardEvent.h"
#include "core/frame/LocalFrame.h"
#include "core/page/EditorClient.h"
......
......@@ -38,6 +38,7 @@
#include "core/editing/EphemeralRange.h"
#include "core/editing/FindInPageCoordinates.h"
#include "core/editing/FindOptions.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/SelectionTemplate.h"
#include "core/editing/VisibleSelection.h"
#include "core/editing/iterators/SearchBuffer.h"
......
......@@ -38,6 +38,7 @@
#include "core/editing/EditingUtilities.h"
#include "core/editing/Editor.h"
#include "core/editing/EphemeralRange.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/PlainTextRange.h"
#include "core/editing/RelocatablePosition.h"
#include "core/editing/SelectionTemplate.h"
......
......@@ -33,6 +33,7 @@
#include "core/editing/EditingUtilities.h"
#include "core/editing/Editor.h"
#include "core/editing/EphemeralRange.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/PlainTextRange.h"
#include "core/editing/SelectionModifier.h"
#include "core/editing/SelectionTemplate.h"
......
......@@ -7,6 +7,7 @@
#include "core/editing/EditingUtilities.h"
#include "core/editing/Editor.h"
#include "core/editing/EphemeralRange.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/SelectionTemplate.h"
#include "core/editing/VisiblePosition.h"
#include "core/editing/commands/CompositeEditCommand.h"
......
......@@ -6,6 +6,7 @@
#include "core/editing/Editor.h"
#include "core/editing/EphemeralRange.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/SelectionTemplate.h"
#include "core/editing/markers/DocumentMarkerController.h"
#include "core/editing/markers/SpellCheckMarker.h"
......
......@@ -51,6 +51,7 @@
#include "core/dom/events/DOMWindowEventQueue.h"
#include "core/dom/events/ScopedEventQueue.h"
#include "core/editing/Editor.h"
#include "core/editing/FrameSelection.h"
#include "core/events/HashChangeEvent.h"
#include "core/events/MessageEvent.h"
#include "core/events/PageTransitionEvent.h"
......
......@@ -39,6 +39,7 @@
#include "core/dom/ElementTraversal.h"
#include "core/editing/EditingTriState.h"
#include "core/editing/Editor.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/markers/DocumentMarkerController.h"
#include "core/editing/markers/SpellCheckMarker.h"
#include "core/editing/spellcheck/SpellChecker.h"
......
......@@ -25,6 +25,7 @@
#include "core/dom/Text.h"
#include "core/editing/EditingUtilities.h"
#include "core/editing/Editor.h"
#include "core/editing/FrameSelection.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/LocalFrameView.h"
#include "core/html/HTMLFrameOwnerElement.h"
......
......@@ -12,6 +12,7 @@
#include "core/clipboard/Pasteboard.h"
#include "core/dom/QualifiedName.h"
#include "core/editing/Editor.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/SelectionTemplate.h"
#include "core/editing/SelectionType.h"
#include "core/editing/VisibleSelection.h"
......
......@@ -60,6 +60,7 @@
#include "core/dom/ViewportDescription.h"
#include "core/editing/Editor.h"
#include "core/editing/EphemeralRange.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/PlainTextRange.h"
#include "core/editing/SelectionTemplate.h"
#include "core/editing/SurroundingText.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment