Commit 879ef3bd authored by Emil A Eklund's avatar Emil A Eklund Committed by Commit Bot

[LayoutNG] Fix DCHECK in NGLineBreaker::ComputeLineLocation

Bug: 999075
Test: fast/text/nowrap-with-saturated-padding.html
Change-Id: Ie8aa9c98ab9cf2f868d24472a2362f54cad19273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775217
Auto-Submit: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691935}
parent 619fe5bb
......@@ -471,7 +471,10 @@ void NGLineBreaker::ComputeLineLocation(NGLineInfo* line_info) const {
// Negative margins can make the position negative, but the inline size is
// always positive or 0.
LayoutUnit available_width = AvailableWidth();
DCHECK_EQ(position_, line_info->ComputeWidth());
// Text measurement is done using floats which may introduce small rounding
// errors for near-saturated values.
DCHECK_EQ(position_.Round(), line_info->ComputeWidth().Round());
line_info->SetWidth(available_width, position_);
line_info->SetBfcOffset(
......
<style>
label { white-space: nowrap; }
meter { padding-right: 99999999px; }
</style>
<script>
if (window.testRunner)
testRunner.dumpAsText();
</script>
<label>
<meter></meter>
</label>
Should not crash
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment