Commit 87a00ce5 authored by Bruce Dawson's avatar Bruce Dawson Committed by Commit Bot

Enforce no use of windows.h in atomicops.h

atomicops.h was fixed in January to not depend on Windows.h anymore.
Update the comment to reflect that, and enforce it in the unit test.

Bug: 559247, 796644
Change-Id: I95762b818d135f6f400e1b9aa66567464aef8951
Reviewed-on: https://chromium-review.googlesource.com/956668Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542240}
parent 0a9fafbb
...@@ -145,8 +145,8 @@ Atomic64 Release_Load(volatile const Atomic64* ptr); ...@@ -145,8 +145,8 @@ Atomic64 Release_Load(volatile const Atomic64* ptr);
} // namespace base } // namespace base
#if defined(OS_WIN) #if defined(OS_WIN)
// TODO(jfb): The MSVC header includes windows.h, which other files end up // TODO(jfb): Try to use base/atomicops_internals_portable.h everywhere.
// relying on. Fix this as part of crbug.com/559247. // https://crbug.com/559247.
# include "base/atomicops_internals_x86_msvc.h" # include "base/atomicops_internals_x86_msvc.h"
#else #else
# include "base/atomicops_internals_portable.h" # include "base/atomicops_internals_portable.h"
......
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
// This file ensures that these header files don't include Windows.h and can // This file ensures that these header files don't include Windows.h and can
// compile without including Windows.h. This helps to improve compile times. // compile without including Windows.h. This helps to improve compile times.
#include "base/atomicops.h"
#include "base/files/file_util.h" #include "base/files/file_util.h"
#include "base/files/platform_file.h" #include "base/files/platform_file.h"
#include "base/process/process_handle.h" #include "base/process/process_handle.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment