Commit 87a6ab34 authored by haraken's avatar haraken Committed by Commit bot

Add NOTREACHED to HeapObjectHeader::markDead()

Now that we've shipped a per-thread heap, a Dead state should not happen.
This CL adds an assert to check the fact.

BUG=

Review-Url: https://codereview.chromium.org/2629853002
Cr-Commit-Position: refs/heads/master@{#443514}
parent cc53e069
...@@ -925,6 +925,9 @@ NO_SANITIZE_ADDRESS inline bool HeapObjectHeader::isDead() const { ...@@ -925,6 +925,9 @@ NO_SANITIZE_ADDRESS inline bool HeapObjectHeader::isDead() const {
} }
NO_SANITIZE_ADDRESS inline void HeapObjectHeader::markDead() { NO_SANITIZE_ADDRESS inline void HeapObjectHeader::markDead() {
// A Dead state should not happen in a per-thread heap world.
// TODO(haraken): Remove code to handle the Dead state.
CHECK(false);
ASSERT(checkHeader()); ASSERT(checkHeader());
ASSERT(!isMarked()); ASSERT(!isMarked());
m_encoded |= headerDeadBitMask; m_encoded |= headerDeadBitMask;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment