Commit 87cc1af1 authored by Gabriel Charette's avatar Gabriel Charette Committed by Commit Bot

[PRESUBMIT] Discourage but don't ban ScopedMockTimeMessageLoopTaskRunner

A valid use case in a browser test was recently presented to me. And
while I ultimately plan to support this in ScopedTaskEnvironment as
well, it isn't for now.

R=dpranke@chromium.org

Bug: None
Change-Id: Id4197c8a8cd567c5daaf4b1b39fe8f34fb8b3549
Reviewed-on: https://chromium-review.googlesource.com/1027809Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553736}
parent 7cc6c436
......@@ -431,9 +431,13 @@ _BANNED_CPP_FUNCTIONS = (
(
'base::ScopedMockTimeMessageLoopTaskRunner',
(
'ScopedMockTimeMessageLoopTaskRunner is deprecated.',
'ScopedMockTimeMessageLoopTaskRunner is deprecated. Prefer',
'ScopedTaskEnvironment::MainThreadType::MOCK_TIME. There are still a',
'few cases that may require a ScopedMockTimeMessageLoopTaskRunner',
'(i.e. mocking the main MessageLoopForUI in browser_tests), but check',
'with gab@ first if you think you need it)',
),
True,
False,
(),
),
(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment