Revert "[iOS] ActivityService cleanup"

This reverts commit 76c127f6.

Reason for revert: This needs to be reverted first to revert crrev.com/c/1172287.

Original change's description:
> [iOS] ActivityService cleanup
>
> Cleanup for the ActivityService.
>
> Bug: none
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I7feb4acc2711172dfb9829c2b223e6f2c724fa33
> Reviewed-on: https://chromium-review.googlesource.com/1172289
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Peter Lee <pkl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582599}

TBR=pkl@chromium.org,gambard@chromium.org

Change-Id: I1a2b122518b7b845274a4d27bc897eb9d195a2dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 873718
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1173891Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582825}

ios/chrome/browser/ui/activity_services/share_to_data.h

@@ -34,12 +34,8 @@
 @property(nonatomic, readonly) NSURL* shareNSURL;
 @property(nonatomic, readonly) NSURL* passwordManagerNSURL;
 
-// Title to be shared (not nil).
 @property(nonatomic, readonly, copy) NSString* title;
-// Whether the title was provided by the page (i.e., was not generated from
-// the url).
 @property(nonatomic, readonly, assign) BOOL isOriginalTitle;
-// Whether the page is printable or not.
 @property(nonatomic, readonly, assign) BOOL isPagePrintable;
 // Whether FindInPage can be enabled for this page.
 @property(nonatomic, readonly, assign) BOOL isPageSearchable;

ios/chrome/browser/ui/activity_services/share_to_data.mm

@@ -14,23 +14,38 @@
 #endif
 
 @interface ShareToData () {
+ @private
   // URL to be shared with share extensions.
-  GURL _shareURL;
+  GURL shareURL_;
 
   // Visible URL of the page.
-  GURL _visibleURL;
+  GURL visibleURL_;
+
+  // Title to be shared (not nil).
+  NSString* title_;
+
+  // Whether the title was provided by the page (i.e., was not generated from
+  // the url).
+  BOOL isOriginalTitle_;
+
+  // Whether the page is printable or not.
+  BOOL isPagePrintable_;
 }
+
+@property(nonatomic, readwrite, copy) NSString* title;
+@property(nonatomic, readwrite, assign) BOOL isOriginalTitle;
+@property(nonatomic, readwrite, assign) BOOL isPagePrintable;
 @end
 
 @implementation ShareToData
 
-@synthesize title = _title;
+@synthesize title = title_;
 @synthesize image = image_;
-@synthesize thumbnailGenerator = _thumbnailGenerator;
-@synthesize isOriginalTitle = _isOriginalTitle;
-@synthesize isPagePrintable = _isPagePrintable;
-@synthesize isPageSearchable = _isPageSearchable;
-@synthesize userAgent = _userAgent;
+@synthesize thumbnailGenerator = thumbnailGenerator_;
+@synthesize isOriginalTitle = isOriginalTitle_;
+@synthesize isPagePrintable = isPagePrintable_;
+@synthesize isPageSearchable = isPageSearchable_;
+@synthesize userAgent = userAgent_;
 
 - (id)initWithShareURL:(const GURL&)shareURL
             visibleURL:(const GURL&)visibleURL
@@ -45,32 +60,32 @@
   DCHECK(title);
   self = [super init];
   if (self) {
-    _shareURL = shareURL;
-    _visibleURL = visibleURL;
-    _title = [title copy];
-    _isOriginalTitle = isOriginalTitle;
-    _isPagePrintable = isPagePrintable;
-    _isPageSearchable = isPageSearchable;
-    _userAgent = userAgent;
-    _thumbnailGenerator = thumbnailGenerator;
+    shareURL_ = shareURL;
+    visibleURL_ = visibleURL;
+    title_ = [title copy];
+    isOriginalTitle_ = isOriginalTitle;
+    isPagePrintable_ = isPagePrintable;
+    isPageSearchable_ = isPageSearchable;
+    userAgent_ = userAgent;
+    thumbnailGenerator_ = thumbnailGenerator;
   }
   return self;
 }
 
 - (const GURL&)shareURL {
-  return _shareURL;
+  return shareURL_;
 }
 
 - (const GURL&)visibleURL {
-  return _visibleURL;
+  return visibleURL_;
 }
 
 - (NSURL*)shareNSURL {
-  return net::NSURLWithGURL(_shareURL);
+  return net::NSURLWithGURL(shareURL_);
 }
 
 - (NSURL*)passwordManagerNSURL {
-  return net::NSURLWithGURL(_visibleURL);
+  return net::NSURLWithGURL(visibleURL_);
 }
 
 @end