Commit 87f7f534 authored by Stefan Zager's avatar Stefan Zager Committed by Commit Bot

Add CHECK's to diagnose crash

BUG=1012596
R=pdr@chromium.org

Change-Id: Ia7b38bc868f37bfe9aca4f276187a2543ae42750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849584Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704272}
parent 47471b33
...@@ -1414,6 +1414,13 @@ const LayoutBoxModelObject* LayoutObject::EnclosingCompositedContainer() const { ...@@ -1414,6 +1414,13 @@ const LayoutBoxModelObject* LayoutObject::EnclosingCompositedContainer() const {
bool LayoutObject::HasDistortingVisualEffects() const { bool LayoutObject::HasDistortingVisualEffects() const {
// TODO(szager): Check occlusion information propagated from out-of-process // TODO(szager): Check occlusion information propagated from out-of-process
// parent frame. // parent frame.
// TODO(szager): Remove CHECK's after diagnosing crash.
PaintLayer* enclosing_layer = EnclosingLayer();
CHECK(enclosing_layer);
CHECK(enclosing_layer->GetLayoutObject()
.FirstFragment()
.HasLocalBorderBoxProperties());
PropertyTreeState paint_properties = EnclosingLayer() PropertyTreeState paint_properties = EnclosingLayer()
->GetLayoutObject() ->GetLayoutObject()
.FirstFragment() .FirstFragment()
...@@ -1430,12 +1437,15 @@ bool LayoutObject::HasDistortingVisualEffects() const { ...@@ -1430,12 +1437,15 @@ bool LayoutObject::HasDistortingVisualEffects() const {
} }
} }
PropertyTreeState root_properties = GetDocument() // TODO(szager): Remove CHECK's after diagnosing crash.
.GetFrame() CHECK(GetDocument().IsActive());
->LocalFrameRoot() LocalFrame* frame = GetDocument().GetFrame();
.ContentLayoutObject() CHECK(frame);
->FirstFragment() LayoutView* layout_view = frame->LocalFrameRoot().ContentLayoutObject();
.LocalBorderBoxProperties(); CHECK(layout_view);
CHECK(layout_view->FirstFragment().HasLocalBorderBoxProperties());
PropertyTreeState root_properties =
layout_view->FirstFragment().LocalBorderBoxProperties();
// The only allowed transforms are 2D translation and proportional up-scaling. // The only allowed transforms are 2D translation and proportional up-scaling.
const auto& translation_2d_or_matrix = const auto& translation_2d_or_matrix =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment