Skip to content

GitLab

T
tangled
Commit 87f9f625 authored by dmazzoni's avatar dmazzoni Committed by Commit bot
Browse files
Options

Revert of Disable some DumpAccessibilityTreeTest.Accessibility test on Windows... 

Revert of Disable some DumpAccessibilityTreeTest.Accessibility test on Windows (patchset #1 id:1 of https://codereview.chromium.org/2309273002/ )

Reason for revert:
Re-enabling these tests because the change that caused the try flakes was reverted here:

https://codereview.chromium.org/2302353005

Original issue's description:
> Disable some DumpAccessibilityTreeTest.Accessibility test on Windows
>
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> TBR=dmazzoni@chromium.org
> BUG=chromium:643954
>
> Committed: https://crrev.com/b7a4685cc72298483cde031c401007f78538d429
> Cr-Commit-Position: refs/heads/master@{#416527}

TBR=magjed@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:643954

Review-Url: https://codereview.chromium.org/2320673003
Cr-Commit-Position: refs/heads/master@{#417082}
parent 2f1a799b
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 30 deletions
content/browser/accessibility/dump_accessibility_tree_browsertest.cc
View file @ 87f9f625
...@@ -120,35 +120,15 @@ class DumpAccessibilityTreeTest : public DumpAccessibilityTestBase { ...@@ -120,35 +120,15 @@ class DumpAccessibilityTreeTest : public DumpAccessibilityTestBase {
} }
}; };
// Flaky on Windows: crbug.com/643954. IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityCSSColor) {
#if defined(OS_WIN)
#define MAYBE_AccessibilityCSSColor DISABLED_AccessibilityCSSColor
#else
#define MAYBE_AccessibilityCSSColor AccessibilityCSSColor
#endif
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, MAYBE_AccessibilityCSSColor) {
RunCSSTest(FILE_PATH_LITERAL("color.html")); RunCSSTest(FILE_PATH_LITERAL("color.html"));
} }
// Flaky on Windows: crbug.com/643954. IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityCSSFontStyle) {
#if defined(OS_WIN)
#define MAYBE_AccessibilityCSSFontStyle DISABLED_AccessibilityCSSFontStyle
#else
#define MAYBE_AccessibilityCSSFontStyle AccessibilityCSSFontStyle
#endif
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
MAYBE_AccessibilityCSSFontStyle) {
RunCSSTest(FILE_PATH_LITERAL("font-style.html")); RunCSSTest(FILE_PATH_LITERAL("font-style.html"));
} }
// Flaky on Windows: crbug.com/643954. IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityCSSLanguage) {
#if defined(OS_WIN)
#define MAYBE_AccessibilityCSSLanguage DISABLED_AccessibilityCSSLanguage
#else
#define MAYBE_AccessibilityCSSLanguage AccessibilityCSSLanguage
#endif
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
MAYBE_AccessibilityCSSLanguage) {
RunCSSTest(FILE_PATH_LITERAL("language.html")); RunCSSTest(FILE_PATH_LITERAL("language.html"));
} }
...@@ -1247,13 +1227,7 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, ...@@ -1247,13 +1227,7 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
RunHtmlTest(FILE_PATH_LITERAL("output.html")); RunHtmlTest(FILE_PATH_LITERAL("output.html"));
} }
// Flaky on Windows: crbug.com/643954. IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityP) {
#if defined(OS_WIN)
#define MAYBE_AccessibilityP DISABLED_AccessibilityP
#else
#define MAYBE_AccessibilityP AccessibilityP
#endif
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, MAYBE_AccessibilityP) {
RunHtmlTest(FILE_PATH_LITERAL("p.html")); RunHtmlTest(FILE_PATH_LITERAL("p.html"));
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment