Commit 88106b1d authored by Jinho Bang's avatar Jinho Bang Committed by Commit Bot

Canvas2D: Remove IsInifinityOrNaN() and use !std::isfinite() instead

According to the reference[1], std::isfinite(NaN) is false. Therefore,
std::isnan() check is unnecessary.

[1] https://en.cppreference.com/w/cpp/numeric/math/isfinite

Bug: 984849, 985067
Change-Id: Ia03fa3cf337101b589938cb83252ddded7ec054f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715465Reviewed-by: default avatarFernando Serboncini <fserb@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#692094}
parent f45542aa
...@@ -39,13 +39,6 @@ ...@@ -39,13 +39,6 @@
#include "third_party/blink/renderer/platform/transforms/affine_transform.h" #include "third_party/blink/renderer/platform/transforms/affine_transform.h"
namespace blink { namespace blink {
namespace {
bool IsInfinityOrNaN(double value) {
return !std::isfinite(value) || std::isnan(value);
}
} // namespace
class ExceptionState; class ExceptionState;
...@@ -74,10 +67,10 @@ class MODULES_EXPORT Path2D final : public ScriptWrappable, public CanvasPath { ...@@ -74,10 +67,10 @@ class MODULES_EXPORT Path2D final : public ScriptWrappable, public CanvasPath {
ExceptionState& exception_state) { ExceptionState& exception_state) {
DOMMatrixReadOnly* matrix = DOMMatrixReadOnly* matrix =
DOMMatrixReadOnly::fromMatrix2D(transform, exception_state); DOMMatrixReadOnly::fromMatrix2D(transform, exception_state);
if (!matrix || IsInfinityOrNaN(matrix->m11()) || if (!matrix || !std::isfinite(matrix->m11()) ||
IsInfinityOrNaN(matrix->m12()) || IsInfinityOrNaN(matrix->m21()) || !std::isfinite(matrix->m12()) || !std::isfinite(matrix->m21()) ||
IsInfinityOrNaN(matrix->m22()) || IsInfinityOrNaN(matrix->m41()) || !std::isfinite(matrix->m22()) || !std::isfinite(matrix->m41()) ||
IsInfinityOrNaN(matrix->m42())) !std::isfinite(matrix->m42()))
return; return;
path_.AddPath(path->GetPath(), matrix->GetAffineTransform()); path_.AddPath(path->GetPath(), matrix->GetAffineTransform());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment