Skip to content

GitLab

T
tangled
Commit 88182a1b authored by David Grogan's avatar David Grogan Committed by Commit Bot
Browse files
Options

[css-tables] Test that tables have box-sizing:border-box by default 

Legacy layout erroneously sets box-sizing:border-box on non-table
elements that have display:table when the element has a specified %
height. Only <table> elements should have box-sizing:border-box.

Bug: 598134
Change-Id: I66a4a6380ca60a88516a63d3df84faabd709d4c0
Reviewed-on: https://chromium-review.googlesource.com/940561
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539916}
parent 90be9e6e
Hide whitespace changes
Inline Side-by-side
Showing with 65 additions and 0 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ 88182a1b
...@@ -245,6 +245,9 @@ crbug.com/417223 external/wpt/css/css-position/position-relative-table-tr-top.ht ...@@ -245,6 +245,9 @@ crbug.com/417223 external/wpt/css/css-position/position-relative-table-tr-top.ht
crbug.com/724697 overflow/overflow-basic-002.html [ Failure ] crbug.com/724697 overflow/overflow-basic-002.html [ Failure ]
crbug.com/724701 overflow/overflow-basic-004.html [ Failure ] crbug.com/724701 overflow/overflow-basic-004.html [ Failure ]
### external/wpt/css/css-tables/
crbug.com/598134 external/wpt/css/css-tables/table-has-box-sizing-border-box-002.html [ Failure ]
# ====== Layout team owned tests to here ====== # ====== Layout team owned tests to here ======
# ====== LayoutNG-only failures from here ====== # ====== LayoutNG-only failures from here ======
......
third_party/WebKit/LayoutTests/external/wpt/css/css-tables/table-has-box-sizing-border-box-001.html 0 → 100644
View file @ 88182a1b
<!DOCTYPE html>
<meta charset="utf-8">
<link rel="author" title="David Grogan" href="dgrogan@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-tables-3/#mapping">
<link rel="match" href="../reference/ref-filled-green-100px-square-only.html">
<link rel="bookmark" href="https://bugs.chromium.org/p/chromium/issues/detail?id=598134" />
<meta name="flags" content="" />
<meta name="assert" content="default box-sizing for <table> is border-box" />
<title>
UA stylesheet, &lt;table>, box-sizing
</title>
<style>
#table {
width: 100px;
height: 100%;
background: green;
padding-bottom: 35px;
}
</style>
<p>Test passes if there is a filled green square.
</p>
<div style="height:100px">
<table id="table"></table>
</div>
third_party/WebKit/LayoutTests/external/wpt/css/css-tables/table-has-box-sizing-border-box-002.html 0 → 100644
View file @ 88182a1b
<!DOCTYPE html>
<meta charset="utf-8">
<link rel="author" title="David Grogan" href="dgrogan@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-tables-3/#mapping">
<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
<link rel="bookmark" href="https://bugs.chromium.org/p/chromium/issues/detail?id=598134" />
<meta name="flags" content="" />
<meta name="assert" content="default <table> box-sizing:border-box is not applied to non-table elements that have display:table" />
<title>
UA stylesheet, &lt;table>, box-sizing
</title>
<style>
#table {
display: table;
width: 100px;
height: 100%;
background: green;
padding-bottom: 35px;
}
#redSquare {
height: 100px;
width: 100px;
background-color: red;
position: absolute;
z-index: -1;
}
</style>
<p>Test passes if there is a filled green square and <strong>no red</strong>.
</p>
<div id="redSquare"></div>
<div style="height:65px">
<div id="table"></div>
</div>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment