[LayoutNG] Decrease the amount that we miss the intrinsic sizes cache.

This adds additional logic to CanUseCachedIntrinsicInlineSizes to use
the cache logic more.

This logic is covered by the "new"
css/css-sizing/intrinsic-percent-replaced-dynamic-*

Change-Id: Ic0cdf68978ba1fb84fa0a586c48da035239fb7a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116531
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756067}

third_party/blink/renderer/core/layout/ng/ng_block_node.cc

@@ -301,26 +301,48 @@ void SetupBoxLayoutExtraInput(const NGConstraintSpace& space,
 }
 
 bool CanUseCachedIntrinsicInlineSizes(const MinMaxSizesInput& input,
-                                      const LayoutBox& box) {
+                                      const NGBlockNode& node,
+                                      bool is_orthogonal_flow_root) {
+  const auto& box = *node.GetLayoutBox();
+
   // Obviously can't use the cache if our intrinsic logical widths are dirty.
   if (box.IntrinsicLogicalWidthsDirty())
     return false;
 
+  if (is_orthogonal_flow_root)
+    return false;
+
   // We don't store the float inline sizes for comparison, always skip the
   // cache in this case.
   if (input.float_left_inline_size || input.float_right_inline_size)
     return false;
 
   // Check if we have any percentage inline padding.
-  const auto& style = box.StyleRef();
+  const auto& style = node.Style();
   if (style.MayHavePadding() && (style.PaddingStart().IsPercentOrCalc() ||
                                  style.PaddingEnd().IsPercentOrCalc()))
     return false;
 
   // Check if the %-block-size matches.
   if (input.percentage_resolution_block_size !=
-      box.IntrinsicLogicalWidthsPercentageResolutionBlockSize())
-    return false;
+      box.IntrinsicLogicalWidthsPercentageResolutionBlockSize()) {
+    // Miss the cache if our children use our %-block-size.
+    if (node.UseParentPercentageResolutionBlockSizeForChildren())
+      return false;
+
+    // OOF-positioned nodes have the %-block-size computed for their children
+    // up front.
+    if (node.IsOutOfFlowPositioned())
+      return false;
+
+    if (node.IsTable())
+      return false;
+
+    if (style.LogicalHeight().IsPercentOrCalc() ||
+        style.LogicalMinHeight().IsPercentOrCalc() ||
+        style.LogicalMaxHeight().IsPercentOrCalc())
+      return false;
+  }
 
   return true;
 }
@@ -660,7 +682,7 @@ MinMaxSizes NGBlockNode::ComputeMinMaxSizes(
   bool is_orthogonal_flow_root =
       !IsParallelWritingMode(container_writing_mode, Style().GetWritingMode());
 
-  if (CanUseCachedIntrinsicInlineSizes(input, *box_))
+  if (CanUseCachedIntrinsicInlineSizes(input, *this, is_orthogonal_flow_root))
     return box_->IntrinsicLogicalWidths();
 
   box_->SetIntrinsicLogicalWidthsDirty();