Commit 88278d2e authored by Matt Jones's avatar Matt Jones Committed by Commit Bot

Remove obsolete overlaypanel logic from BottomSheetController

This patch removes logic that would prevent the bottom sheet from
showing when contextual search was visible. The code in question was
relevant when the bottom sheet could trigger without a user action.
Since this is no longer the case, the code is unneeded. This block of
code should have been removed with https://crrev.com/c/1808180, which
contained the rest of this logic.

Bug: 100227
Change-Id: I6c1896c9c8907ec01542568162291e85aa2892cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204298Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773337}
parent c5b91d68
......@@ -552,8 +552,8 @@ public class BottomSheetController implements Destroyable {
*/
@VisibleForTesting
void unsuppressSheet() {
if (!mIsSuppressed || mTabProvider.get() == null || isOtherUIObscuring()
|| VrModuleProvider.getDelegate().isInVr() || mOmniboxFocusStateSupplier.get()) {
if (!mIsSuppressed || mTabProvider.get() == null || VrModuleProvider.getDelegate().isInVr()
|| mOmniboxFocusStateSupplier.get()) {
return;
}
mIsSuppressed = false;
......@@ -761,14 +761,6 @@ public class BottomSheetController implements Destroyable {
}
}
/**
* @return Whether some other UI is preventing the sheet from showing.
*/
private boolean isOtherUIObscuring() {
return mOverlayPanelManager.get() != null
&& mOverlayPanelManager.get().getActivePanel() != null;
}
/**
* The bottom sheet cannot change content while it is open. If the user has the bottom sheet
* open, they are currently engaged in a task and shouldn't be interrupted.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment