[css-grid] Wipe SizingOperation out

crrev.com/2823183003 was the first step towards removing the SizingOperation
enum which was added in the past as a convenient way to modify the track
sizing algorithm behaviour depending on whether the size was
indefinite/definite but also on whether we were computing the grid intrinsic
size or doing a layout. As mentioned in the CL above that was a mistake
because indefinite sizes do not always correspond to preferred widths
computations.

Now that we have the algorithm in a separate class with different strategies
the existence of that enum is no longer required. We can handle the
remaining code path using SizingOperation just by using the algorithm
strategies.

No new tests required as this does not imply a change in the behaviour.

Review-Url: https://codereview.chromium.org/2842413003
Cr-Commit-Position: refs/heads/master@{#468599}

third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp

@@ -324,8 +324,7 @@ LayoutUnit GridTrackSizingAlgorithmStrategy::MinContentForChild(
     return child.MinPreferredLogicalWidth() + margin_logical_width;
   }
 
-  if (Direction() == kForColumns &&
-      algorithm_.sizing_operation_ == kIntrinsicSizeComputation) {
+  if (Direction() == kForColumns && !AvailableSpace()) {
     DCHECK(GetLayoutGrid()->IsOrthogonalChild(child));
     if (GetLayoutGrid()->IsBaselineAlignmentForChild(child, kGridRowAxis) &&
         GetLayoutGrid()->IsBaselineContextComputed(kGridRowAxis)) {
@@ -1405,7 +1404,6 @@ bool GridTrackSizingAlgorithm::IsValidTransition() const {
 
 void GridTrackSizingAlgorithm::Setup(GridTrackSizingDirection direction,
                                      size_t num_tracks,
-                                     SizingOperation sizing_operation,
                                      Optional<LayoutUnit> available_space,
                                      Optional<LayoutUnit> free_space) {
   DCHECK(needs_setup_);
@@ -1415,8 +1413,6 @@ void GridTrackSizingAlgorithm::Setup(GridTrackSizingDirection direction,
       direction, available_space ? available_space.value().ClampNegativeToZero()
                                  : available_space);
 
-  sizing_operation_ = sizing_operation;
-
   if (available_space)
     strategy_ = WTF::MakeUnique<DefiniteSizeStrategy>(*this);
   else

third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.h

@@ -21,8 +21,6 @@ class Grid;
 class GridTrackSizingAlgorithmStrategy;
 class LayoutGrid;
 
-enum SizingOperation { kTrackSizing, kIntrinsicSizeComputation };
-
 enum TrackSizeComputationPhase {
   kResolveIntrinsicMinimums,
   kResolveContentBasedMinimums,
@@ -86,7 +84,6 @@ class GridTrackSizingAlgorithm final {
   // the algorithm.
   void Setup(GridTrackSizingDirection,
              size_t num_tracks,
-             SizingOperation,
              Optional<LayoutUnit> available_space,
              Optional<LayoutUnit> free_space);
   void Run();
@@ -190,7 +187,6 @@ class GridTrackSizingAlgorithm final {
   Vector<size_t> flexible_sized_tracks_index_;
 
   GridTrackSizingDirection direction_;
-  SizingOperation sizing_operation_;
 
   Grid& grid_;
 

third_party/WebKit/Source/core/layout/LayoutGrid.cpp

@@ -174,7 +174,7 @@ void LayoutGrid::ComputeTrackSizesForDefiniteSize(
                                     grid_.NumTracks(direction),
                                     available_space);
   track_sizing_algorithm_.Setup(direction, NumTracks(direction, grid_),
-                                kTrackSizing, available_space, free_space);
+                                available_space, free_space);
   track_sizing_algorithm_.Run();
 
 #if DCHECK_IS_ON()
@@ -474,8 +474,8 @@ void LayoutGrid::ComputeTrackSizesForIndefiniteSize(
     Grid& grid,
     LayoutUnit& min_intrinsic_size,
     LayoutUnit& max_intrinsic_size) const {
-  algo.Setup(direction, NumTracks(direction, grid), kIntrinsicSizeComputation,
-             WTF::kNullopt, WTF::kNullopt);
+  algo.Setup(direction, NumTracks(direction, grid), WTF::kNullopt,
+             WTF::kNullopt);
   algo.Run();
 
   min_intrinsic_size = algo.MinContentSize();