Cleanup: Style fixes in extensions/browser

1) Fix Namespace comment in admin_policy.h
2) Mark explicit to single-argument constructors in file_highlighter.h
   and test_extensions_browser_client.h
3) Use CHECK_GT instead of CHECK in process_manager.cc

BUG=

Review URL: https://codereview.chromium.org/308913006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274475 0039d316-1c4b-4281-b951-d872f2087c98
parent 6fc31fbc
......@@ -36,7 +36,7 @@ bool UserMayModifySettings(const Extension* extension, base::string16* error);
// this enforces the admin policy forcelist.
bool MustRemainEnabled(const Extension* extension, base::string16* error);
} // namespace
} // namespace admin_policy
} // namespace extensions
#endif // EXTENSIONS_BROWSER_ADMIN_POLICY_H_
......@@ -41,7 +41,7 @@ class FileHighlighter {
void SetHighlightedRegions(base::DictionaryValue* dict) const;
protected:
FileHighlighter(const std::string& contents);
explicit FileHighlighter(const std::string& contents);
// The contents of the file we are parsing.
std::string contents_;
......
......@@ -257,7 +257,7 @@ ProcessManager::ProcessManager(BrowserContext* context,
unsigned idle_time_msec = 0;
if (base::StringToUint(CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
extensions::switches::kEventPageIdleTime), &idle_time_msec)) {
CHECK(idle_time_msec > 0); // OnKeepaliveImpulseCheck requires non zero.
CHECK_GT(idle_time_msec, 0u); // OnKeepaliveImpulseCheck requires non zero.
event_page_idle_time_ = base::TimeDelta::FromMilliseconds(idle_time_msec);
}
event_page_suspending_time_ = base::TimeDelta::FromSeconds(5);
......
......@@ -16,7 +16,7 @@ namespace extensions {
class TestExtensionsBrowserClient : public ExtensionsBrowserClient {
public:
// |context| is required and must not be an incognito context.
TestExtensionsBrowserClient(content::BrowserContext* main_context);
explicit TestExtensionsBrowserClient(content::BrowserContext* main_context);
virtual ~TestExtensionsBrowserClient();
// Associates an incognito context with |main_context_|.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment