Commit 88495d66 authored by Ken Rockot's avatar Ken Rockot Committed by Commit Bot

Add temporary CHECK to investigate bad IPCs

BigBuffer intentionally constructs a malformed object when it can't
provide a suitable representation of its contents for transmission. This
is suspected to be the underlying cause for a few assorted bad IPC
reports.

This CL adds a temporary CHECK to investigate that hypothesis.

Bug: 1076341, 1087814
Tbr: dcheng@chromium.org
Change-Id: I2e07f3fcb9642034987e8bf3194b6817fbd701c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231584Reviewed-by: default avatarKen Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#775304}
parent 5034e855
......@@ -67,6 +67,10 @@ void TryCreateSharedMemory(
// instead produce an invalid buffer. This will always fail validation on
// the receiving end.
*storage_type = BigBuffer::StorageType::kInvalidBuffer;
// TODO(crbug.com/1076341): Remove this temporary CHECK to investigate
// some bad IPC reports likely caused by this path.
CHECK(false);
return;
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment