Commit 88698664 authored by Jack Lynch's avatar Jack Lynch Committed by Commit Bot

DevTools: Fix and re-enable ListControl test

The changes to UI.ListControl in [1] break a web test, so this CL exists
to fix and re-enable it once the product changes merge.

[1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880309

Bug: 963183
Change-Id: Ifd52271fdd1d43f45e4635ba3ac88a3cdb80fe07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690089Reviewed-by: default avatarLorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#723611}
parent 0d091fb6
...@@ -6073,9 +6073,6 @@ crbug.com/878878 [ Mac ] virtual/threaded/fast/scroll-snap/snaps-for-different-k ...@@ -6073,9 +6073,6 @@ crbug.com/878878 [ Mac ] virtual/threaded/fast/scroll-snap/snaps-for-different-k
crbug.com/878878 virtual/threaded/fast/scroll-snap/animate-fling-to-snap-points.html [ Failure Pass Timeout ] crbug.com/878878 virtual/threaded/fast/scroll-snap/animate-fling-to-snap-points.html [ Failure Pass Timeout ]
crbug.com/878878 virtual/threaded/fast/scroll-snap/snap-scrolls-visual-viewport.html [ Failure Pass ] crbug.com/878878 virtual/threaded/fast/scroll-snap/snap-scrolls-visual-viewport.html [ Failure Pass ]
# DevTools ListControl (disabled temporarily as part of workflow)
crbug.com/963183 http/tests/devtools/unit/list-control-equal-height.js [ Skip ]
# Sheriff 2019-12-10 # Sheriff 2019-12-10
crbug.com/1032451 virtual/threaded-no-composited-antialiasing/animations/stability/animation-iteration-event-destroy-renderer.html [ Pass Timeout ] crbug.com/1032451 virtual/threaded-no-composited-antialiasing/animations/stability/animation-iteration-event-destroy-renderer.html [ Pass Timeout ]
......
...@@ -29,6 +29,10 @@ ...@@ -29,6 +29,10 @@
if (toElement) if (toElement)
toElement.classList.add('selected'); toElement.classList.add('selected');
} }
updateSelectedItemARIA(fromElement, toElement) {
return false;
}
} }
var delegate = new Delegate(); var delegate = new Delegate();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment