Commit 886f65d8 authored by Vasilii Sukhanov's avatar Vasilii Sukhanov Committed by Commit Bot

Fix SimulateKeyPress test function to be able to generate lower-case input.

Currently the function always generates capital letters regardless of the parameters.

Change-Id: I7b1f11743c3ba2463e7fd5268d29400d3c71792b
Reviewed-on: https://chromium-review.googlesource.com/1056533Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558640}
parent 39970a79
...@@ -224,7 +224,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest, ...@@ -224,7 +224,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
// take time to propagate to the renderer's main thread. // take time to propagate to the renderer's main thread.
content::DOMMessageQueue msg_queue; content::DOMMessageQueue msg_queue;
std::string reply; std::string reply;
SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('f'), SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('F'),
ui::DomCode::US_F, ui::VKEY_F, false, false, false, false); ui::DomCode::US_F, ui::VKEY_F, false, false, false, false);
EXPECT_TRUE(msg_queue.WaitForMessage(&reply)); EXPECT_TRUE(msg_queue.WaitForMessage(&reply));
EXPECT_EQ("\"F\"", reply); EXPECT_EQ("\"F\"", reply);
......
...@@ -277,8 +277,15 @@ void BuildSimpleWebKeyEvent(blink::WebInputEvent::Type type, ...@@ -277,8 +277,15 @@ void BuildSimpleWebKeyEvent(blink::WebInputEvent::Type type,
if (type == blink::WebInputEvent::kChar || if (type == blink::WebInputEvent::kChar ||
type == blink::WebInputEvent::kRawKeyDown) { type == blink::WebInputEvent::kRawKeyDown) {
event->text[0] = key_code; // |key| is the only parameter that contains information about the case of
event->unmodified_text[0] = key_code; // the character. Use it to be able to generate lower case input.
if (key.IsCharacter()) {
event->text[0] = key.ToCharacter();
event->unmodified_text[0] = key.ToCharacter();
} else {
event->text[0] = key_code;
event->unmodified_text[0] = key_code;
}
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment