Commit 8880b3fd authored by Thomas Tangl's avatar Thomas Tangl Committed by Commit Bot

[profile-menu] Add user action ProfileMenu_Opened

Bug: 966388
Change-Id: I9c4537e1802ac08407c28db2139806ecefc9d149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763753
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689128}
parent 0ac4f8fb
...@@ -137,7 +137,6 @@ ProfileMenuView::ProfileMenuView(views::Button* anchor_button, ...@@ -137,7 +137,6 @@ ProfileMenuView::ProfileMenuView(views::Button* anchor_button,
browser->profile())) { browser->profile())) {
GetViewAccessibility().OverrideName(GetAccessibleWindowTitle()); GetViewAccessibility().OverrideName(GetAccessibleWindowTitle());
chrome::RecordDialogCreation(chrome::DialogIdentifier::PROFILE_CHOOSER); chrome::RecordDialogCreation(chrome::DialogIdentifier::PROFILE_CHOOSER);
base::RecordAction(base::UserMetricsAction("ProfileChooser_Show"));
set_close_on_deactivate(close_on_deactivate_for_testing_); set_close_on_deactivate(close_on_deactivate_for_testing_);
} }
......
...@@ -74,6 +74,8 @@ void ProfileMenuViewBase::ShowBubble( ...@@ -74,6 +74,8 @@ void ProfileMenuViewBase::ShowBubble(
if (IsShowing()) if (IsShowing())
return; return;
base::RecordAction(base::UserMetricsAction("ProfileMenu_Opened"));
ProfileMenuViewBase* bubble; ProfileMenuViewBase* bubble;
if (view_mode == profiles::BUBBLE_VIEW_MODE_INCOGNITO) { if (view_mode == profiles::BUBBLE_VIEW_MODE_INCOGNITO) {
DCHECK(browser->profile()->IsIncognitoProfile()); DCHECK(browser->profile()->IsIncognitoProfile());
......
...@@ -17366,6 +17366,7 @@ should be able to be added at any place in this file. ...@@ -17366,6 +17366,7 @@ should be able to be added at any place in this file.
</action> </action>
<action name="ProfileChooser_Show"> <action name="ProfileChooser_Show">
<obsolete>This is replaced with ProfileMenu_Opened.</obsolete>
<owner>vasilii@chromium.org</owner> <owner>vasilii@chromium.org</owner>
<owner>ewald@chromium.org</owner> <owner>ewald@chromium.org</owner>
<description>The user opened the profile chooser menu.</description> <description>The user opened the profile chooser menu.</description>
...@@ -17395,6 +17396,12 @@ should be able to be added at any place in this file. ...@@ -17395,6 +17396,12 @@ should be able to be added at any place in this file.
</description> </description>
</action> </action>
<action name="ProfileMenu_Opened">
<owner>msarda@chromium.org</owner>
<owner>tangltom@chromium.org</owner>
<description>The user opened the profile menu.</description>
</action>
<action name="PWAInstallIcon"> <action name="PWAInstallIcon">
<owner>alancutter@chromium.org</owner> <owner>alancutter@chromium.org</owner>
<description> <description>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment