Commit 888b6b53 authored by Dominic Farolino's avatar Dominic Farolino Committed by Commit Bot

Remove console deprecation web features

This CL removes the console deprecation web features as well as fixes
more tests that fail with the deprecated console methods removed. Until
the v8 CL that actually removes these deprecated methods lands however,
we have to disable tests on the Chromium side until v8 auto-rolls with
the removed methods. See crrev.com/c/10821128.

Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/pNn_QZxtRlg

R=kozyatinskiy@chromium.org, mkwst@chromium.org

Bug: 706804
Change-Id: I14f4b43373941871333389c9fc8f0f3f770d71b6
Reviewed-on: https://chromium-review.googlesource.com/1105628Reviewed-by: default avatarMike West <mkwst@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#569580}
parent 39396141
......@@ -3832,8 +3832,6 @@ crbug.com/709227 external/wpt/offscreen-canvas/the-offscreen-canvas/size.attribu
crbug.com/709227 external/wpt/offscreen-canvas/the-offscreen-canvas/size.attributes.parse.percent.worker.html [ Failure ]
crbug.com/709227 external/wpt/offscreen-canvas/the-offscreen-canvas/size.attributes.parse.trailingjunk.worker.html [ Failure ]
crbug.com/709227 external/wpt/user-timing/invoke_with_timing_attributes.worker.html [ Failure ]
crbug.com/706804 external/wpt/console/console-tests-historical.any.html [ Skip ]
crbug.com/706804 external/wpt/console/console-tests-historical.any.worker.html [ Skip ]
# Crashes
crbug.com/709227 external/wpt/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.nocontext.worker.html [ Crash ]
......@@ -3849,6 +3847,11 @@ crbug.com/181374 external/wpt/css/css-display/display-contents-dynamic-table-001
# ====== End of display: contents tests ======
# Temporarily disabled tests that will pass once deprecated console methods are removed, see crrev.com/c/1082112
crbug.com/706804 external/wpt/console/console-tests-historical.any.html [ Skip ]
crbug.com/706804 external/wpt/console/console-tests-historical.any.worker.html [ Skip ]
crbug.com/706804 fast/workers/chromium/worker-console-log.html [ Skip ]
crbug.com/676229 [ Win Linux Mac ] plugins/mouse-click-plugin-clears-selection.html [ Failure Pass ]
crbug.com/736333 [ Win7 Linux ] plugins/iframe-plugin-bgcolor.html [ Failure Pass ]
crbug.com/742670 [ Mac ] plugins/iframe-plugin-bgcolor.html [ Failure Pass ]
......
......@@ -41,7 +41,6 @@
console.timeEnd("time");
console.assert(true);
console.assert(false);
console.markTimeline("markTimeline");
*/
self.addEventListener("connect", function (e) {
var port = e.ports[0];
......
......@@ -7,7 +7,6 @@ CONSOLE MESSAGE: line 7: info
CONSOLE DEBUG: line 8: debug
CONSOLE DEBUG: line 9: count: 1
CONSOLE ERROR: line 16: console.assert
CONSOLE WARNING: line 17: 'console.markTimeline' is deprecated. Please use 'console.timeStamp' instead.
This tests that 'console.log' and friends function correctly from workers.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
......@@ -38,7 +38,6 @@
*/
console.assert(true);
console.assert(false);
console.markTimeline("markTimeline");
this.postMessage({ done: true });
</script>
<script>
......
......@@ -6,7 +6,7 @@
<script>
const kFeature = 675; // From UseCounter.h
const kDeprecatedFeature = 538; // From Deprecation.h
const kDeprecatedFeature = 166; // From Deprecation.h
function isUseCounted(win, feature) {
return win.internals.isUseCounted(win.document, feature);
......
......@@ -7,7 +7,7 @@
<script>
const kFeature = 675; // From UseCounter.h
const kDeprecatedFeature = 538; // From Deprecation.h
const kDeprecatedFeature = 166; // From Deprecation.h
function isUseCounted(win, feature) {
return win.internals.isUseCounted(win.document, feature);
......
......@@ -73,7 +73,6 @@ enum WebFeature {
kLineClamp = 96,
kSubFrameBeforeUnloadRegistered = 97,
kSubFrameBeforeUnloadFired = 98,
kConsoleMarkTimeline = 102,
kDocumentCreateAttribute = 111,
kDocumentCreateAttributeNS = 112,
kDocumentXMLEncoding = 115, // Removed from DOM4.
......@@ -316,8 +315,6 @@ enum WebFeature {
kNotificationCreated = 533,
kNotificationClosed = 534,
kNotificationPermissionRequested = 535,
kConsoleTimeline = 538,
kConsoleTimelineEnd = 539,
kSRIElementWithMatchingIntegrityAttribute = 540,
kSRIElementWithNonMatchingIntegrityAttribute = 541,
kSRIElementWithUnparsableIntegrityAttribute = 542,
......
......@@ -182,10 +182,6 @@ DeprecationInfo GetDeprecationInfo(WebFeature feature) {
"'navigator.webkitTemporaryStorage' or "
"'navigator.webkitPersistentStorage'")};
case WebFeature::kConsoleMarkTimeline:
return {"ConsoleMarkTimeline", kUnknown,
ReplacedBy("'console.markTimeline'", "'console.timeStamp'")};
case WebFeature::kPrefixedVideoSupportsFullscreen:
return {"PrefixedVideoSupportsFullscreen", kUnknown,
ReplacedBy("'HTMLVideoElement.webkitSupportsFullscreen'",
......@@ -231,14 +227,6 @@ DeprecationInfo GetDeprecationInfo(WebFeature feature) {
"<source src> with a <picture> parent is invalid and therefore "
"ignored. Please use <source srcset> instead."};
case WebFeature::kConsoleTimeline:
return {"ConsoleTimeline", kUnknown,
ReplacedBy("'console.timeline'", "'console.time'")};
case WebFeature::kConsoleTimelineEnd:
return {"ConsoleTimelineEnd", kUnknown,
ReplacedBy("'console.timelineEnd'", "'console.timeEnd'")};
case WebFeature::kXMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload:
return {"XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload",
kUnknown,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment