Commit 888c0ffd authored by Ahmed Fakhry's avatar Ahmed Fakhry Committed by Commit Bot

Revert "Avoid cycle in Accessibility tree"

This reverts commit f3e4b94f.

Reason for revert: This broke tast.arc.VirtualDesks tests which makes use of the automation API to verify the window tree.

BUG=b/145555421

Original change's description:
> Avoid cycle in Accessibility tree
> 
> This is a temporary fix. By ignoring the node when it is invisible, we
> avoid navigating the cycle repeatedly. However the underlying issue
> is not addressed, and requires further investigation.
> 
> Bug: 1020733
> Change-Id: I70334259b4f271256f21dab47271f7a8346f1f7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919434
> Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717755}

TBR=dtseng@chromium.org,anastasi@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1020733
Change-Id: I94cbac6cc42289eee336a0dca7c85452bf7ec4ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947638Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721165}
parent 8c240c45
...@@ -105,12 +105,8 @@ void AXWindowObjWrapper::Serialize(ui::AXNodeData* out_node_data) { ...@@ -105,12 +105,8 @@ void AXWindowObjWrapper::Serialize(ui::AXNodeData* out_node_data) {
out_node_data->role = ax::mojom::Role::kWindow; out_node_data->role = ax::mojom::Role::kWindow;
out_node_data->AddStringAttribute(ax::mojom::StringAttribute::kName, out_node_data->AddStringAttribute(ax::mojom::StringAttribute::kName,
base::UTF16ToUTF8(window_->GetTitle())); base::UTF16ToUTF8(window_->GetTitle()));
if (!window_->IsVisible()) { if (!window_->IsVisible())
out_node_data->AddState(ax::mojom::State::kInvisible); out_node_data->AddState(ax::mojom::State::kInvisible);
// TODO(crbug/1020733): Find and address the root cause of the cycle, then
// remove the line below.
out_node_data->AddState(ax::mojom::State::kIgnored);
}
out_node_data->relative_bounds.bounds = out_node_data->relative_bounds.bounds =
gfx::RectF(window_->GetBoundsInScreen()); gfx::RectF(window_->GetBoundsInScreen());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment