Commit 889200f2 authored by John Lee's avatar John Lee Committed by Commit Bot

PDF Viewer: Align expand arrows to first line of text

https://imgur.com/a/8EY34XX

Bug: 1123227
Change-Id: Idf4d10b8b4a9652df8fb8876ad7b0d497e289347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390996
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: default avatardpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804348}
parent 1d15ab1e
<style> <style>
#item { #item {
align-items: center; align-items: flex-start;
cursor: pointer; cursor: pointer;
display: flex; display: flex;
height: 30px; height: 30px;
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
:host-context([pdf-viewer-update-enabled]) #item { :host-context([pdf-viewer-update-enabled]) #item {
height: initial; height: initial;
padding: 5px 0;
} }
#item:hover { #item:hover {
...@@ -34,11 +35,28 @@ ...@@ -34,11 +35,28 @@
white-space: initial; white-space: initial;
} }
#expand-container {
--expand-button-size: 28px;
flex-shrink: 0;
position: relative;
width: var(--expand-button-size);
}
/* Forces #expand-container to have a height of 1 line-height. */
#expand-container::before {
content: '.';
visibility: hidden;
}
#expand { #expand {
--cr-icon-button-fill-color: var(--primary-text-color); --cr-icon-button-fill-color: var(--primary-text-color);
--cr-icon-button-icon-size: 16px; --cr-icon-button-icon-size: 16px;
--cr-icon-button-size: 28px; --cr-icon-button-size: var(--expand-button-size);
left: 0;
margin: 0; margin: 0;
position: absolute;
/* Vertically aligns the expand icon with the first line of #title. */
top: calc((100% - var(--cr-icon-button-size)) / 2);
transition: transform 150ms; transition: transform 150ms;
} }
...@@ -51,8 +69,10 @@ ...@@ -51,8 +69,10 @@
} }
</style> </style>
<div id="item" on-click="onClick_"> <div id="item" on-click="onClick_">
<cr-icon-button id="expand" iron-icon="cr:chevron-right" <div id="expand-container">
on-click="toggleChildren_"></cr-icon-button> <cr-icon-button id="expand" iron-icon="cr:chevron-right"
on-click="toggleChildren_"></cr-icon-button>
</div>
<span id="title" tabindex="0">[[bookmark.title]]</span> <span id="title" tabindex="0">[[bookmark.title]]</span>
</div> </div>
<!-- dom-if will stamp the complex bookmark tree lazily as individual nodes <!-- dom-if will stamp the complex bookmark tree lazily as individual nodes
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment