Remove set_sources_assignment_filter from //components/gcm_driver

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: I95e88c9c5592c1425f2a3ded0b59d72c6a1bd0e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410397
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807390}

components/gcm_driver/BUILD.gn

@@ -5,6 +5,12 @@
 import("//build/buildflag_header.gni")
 import("//components/gcm_driver/config.gni")
 
+# Reset sources_assignment_filter for the BUILD.gn file to prevent
+# regression during the migration of Chromium away from the feature.
+# See docs/no_sources_assignment_filter.md for more information.
+# TODO(crbug.com/1018739): remove this when migration is done.
+set_sources_assignment_filter([])
+
 buildflag_header("gcm_buildflags") {
   header = "gcm_buildflags.h"
   flags = [ "USE_GCM_FROM_PLATFORM=$use_gcm_from_platform" ]
@@ -81,6 +87,7 @@ static_library("gcm_driver") {
   }
 
   if (use_gcm_from_platform) {
+    assert(is_android)
     sources += [
       "gcm_driver_android.cc",
       "gcm_driver_android.h",
@@ -167,10 +174,7 @@ static_library("test_support") {
 source_set("unit_tests") {
   testonly = true
 
-  sources = [
-    "gcm_delayed_task_controller_unittest.cc",
-    "gcm_stats_recorder_android_unittest.cc",
-  ]
+  sources = [ "gcm_delayed_task_controller_unittest.cc" ]
 
   deps = [
     ":gcm_driver",
@@ -188,6 +192,10 @@ source_set("unit_tests") {
     "//third_party/protobuf:protobuf_lite",
   ]
 
+  if (is_android) {
+    sources += [ "gcm_stats_recorder_android_unittest.cc" ]
+  }
+
   if (!use_gcm_from_platform) {
     sources += [
       "account_tracker_unittest.cc",

components/gcm_driver/config.gni

@@ -7,3 +7,6 @@ declare_args() {
   # includes GMS which provides the GCM client.
   use_gcm_from_platform = is_android
 }
+
+# Using the platform GCM is only supported on Android.
+assert(!use_gcm_from_platform || is_android)

components/gcm_driver/instance_id/BUILD.gn

@@ -8,14 +8,18 @@ if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
+# Reset sources_assignment_filter for the BUILD.gn file to prevent
+# regression during the migration of Chromium away from the feature.
+# See docs/no_sources_assignment_filter.md for more information.
+# TODO(crbug.com/1018739): remove this when migration is done.
+set_sources_assignment_filter([])
+
 static_library("instance_id") {
   sources = [
     "instance_id.cc",
     "instance_id.h",
     "instance_id_driver.cc",
     "instance_id_driver.h",
-    "instance_id_impl.cc",
-    "instance_id_impl.h",
     "instance_id_profile_service.cc",
     "instance_id_profile_service.h",
   ]
@@ -30,15 +34,17 @@ static_library("instance_id") {
   ]
 
   if (use_gcm_from_platform) {
-    sources -= [
-      "instance_id_impl.cc",
-      "instance_id_impl.h",
-    ]
+    assert(is_android)
     sources += [
       "instance_id_android.cc",
       "instance_id_android.h",
     ]
     deps += [ "android:jni_headers" ]
+  } else {
+    sources += [
+      "instance_id_impl.cc",
+      "instance_id_impl.h",
+    ]
   }
 }
 
@@ -47,8 +53,6 @@ static_library("test_support") {
   sources = [
     "fake_gcm_driver_for_instance_id.cc",
     "fake_gcm_driver_for_instance_id.h",
-    "scoped_use_fake_instance_id_android.cc",
-    "scoped_use_fake_instance_id_android.h",
   ]
 
   public_deps = [ ":instance_id" ]
@@ -59,6 +63,10 @@ static_library("test_support") {
   ]
 
   if (is_android) {
+    sources += [
+      "scoped_use_fake_instance_id_android.cc",
+      "scoped_use_fake_instance_id_android.h",
+    ]
     deps += [ "android:test_support_jni_headers" ]
   }
 }