Commit 88a573fd authored by erikchen's avatar erikchen Committed by Commit Bot

Add a handle validity check before getting pid.

Change-Id: Icbfecced7e68f62c7f9eca0623ddf35a9a241c24
Reviewed-on: https://chromium-review.googlesource.com/1053960Reviewed-by: default avatarSiddhartha S <ssid@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558131}
parent cfd0d899
...@@ -326,11 +326,13 @@ void MemoryInternalsDOMHandler::ReturnProcessListOnUIThread( ...@@ -326,11 +326,13 @@ void MemoryInternalsDOMHandler::ReturnProcessListOnUIThread(
// Append renderer processes. // Append renderer processes.
auto iter = content::RenderProcessHost::AllHostsIterator(); auto iter = content::RenderProcessHost::AllHostsIterator();
while (!iter.IsAtEnd()) { while (!iter.IsAtEnd()) {
base::ProcessId renderer_pid = iter.GetCurrentValue()->GetProcess().Pid(); if (iter.GetCurrentValue()->GetProcess().IsValid()) {
if (renderer_pid != 0) { base::ProcessId renderer_pid = iter.GetCurrentValue()->GetProcess().Pid();
// TODO(brettw) make a better description of the process, maybe see if (renderer_pid != 0) {
// what TaskManager does to get the page title. // TODO(brettw) make a better description of the process, maybe see
process_list.push_back(MakeProcessInfo(renderer_pid, "Renderer")); // what TaskManager does to get the page title.
process_list.push_back(MakeProcessInfo(renderer_pid, "Renderer"));
}
} }
iter.Advance(); iter.Advance();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment