Commit 88ba6722 authored by Istiaque Ahmed's avatar Istiaque Ahmed Committed by Commit Bot

[Extensions] Remove extension reloading in EventsToStoppedWorker test.

Loading unpacked extension causes an extension to reload quickly, which
makes EventsToStoppedWorker test heavily flaky with SW storage migration CL
(ref: https://chromium-review.googlesource.com/c/chromium/src/+/2243071).
This CL packs and loads the extension instead to avoid the reload.

Bug: 1095959
Test: Locally running the test 2000 times didn't flake in cloudtop linux build.
Change-Id: I79f37a4e5721d1d995fddb20f31c6efb95066e60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318508Reviewed-by: default avatarDavid Bertoni <dbertoni@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791416}
parent 77e6161b
...@@ -1660,9 +1660,11 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest, ...@@ -1660,9 +1660,11 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest,
ExtensionTestMessageListener event_listener_added("ready", false); ExtensionTestMessageListener event_listener_added("ready", false);
event_listener_added.set_failure_message("ERROR"); event_listener_added.set_failure_message("ERROR");
// Note: Extension is packed to avoid reloading while loading.
const Extension* extension = LoadExtensionWithFlags( const Extension* extension = LoadExtensionWithFlags(
test_data_dir_.AppendASCII( PackExtension(test_data_dir_.AppendASCII(
"service_worker/worker_based_background/events_to_stopped_worker"), "service_worker/worker_based_background/events_to_stopped_worker")),
kFlagNone); kFlagNone);
ASSERT_TRUE(extension); ASSERT_TRUE(extension);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment