Commit 88c83a45 authored by Xianzhu Wang's avatar Xianzhu Wang Committed by Commit Bot

Explicitly enable SignedExchanged* features for web tests

This CL (temporarily) explicitly enable SignedExchanged* for web
tests. Two tests under external/wpt/signed-exchange/subresource are
rebaselined. virtual/sxg-subresource is removed.

This is to sepearte the change of web test expectations from
crrev.com/c/2375886 which will enable the feature for web tests by
adjusting the application order of blink feature status and chromium
feature status.

Bug: 1121839
Change-Id: I240be44a74a72604dcecc4aad34c0ca70a4e76e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378738Reviewed-by: default avatarTsuyoshi Horo <horo@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802444}
parent 911c0aaf
...@@ -605,6 +605,8 @@ void SetCustomizedRuntimeFeaturesFromCombinedArgs( ...@@ -605,6 +605,8 @@ void SetCustomizedRuntimeFeaturesFromCombinedArgs(
// these features. // these features.
if (enable_experimental_web_platform_features) { if (enable_experimental_web_platform_features) {
WebRuntimeFeatures::EnableNetInfoDownlinkMax(true); WebRuntimeFeatures::EnableNetInfoDownlinkMax(true);
WebRuntimeFeatures::EnableSignedExchangePrefetchCacheForNavigations(true);
WebRuntimeFeatures::EnableSignedExchangeSubresourcePrefetch(true);
} }
if (enable_blink_test_features) { if (enable_blink_test_features) {
......
...@@ -38,8 +38,8 @@ crbug.com/901056 scrollingcoordinator/donot-compute-non-fast-scrollable-region-f ...@@ -38,8 +38,8 @@ crbug.com/901056 scrollingcoordinator/donot-compute-non-fast-scrollable-region-f
### virtual/composite-after-paint/scrollingcoordinator/ ### virtual/composite-after-paint/scrollingcoordinator/
crbug.com/901056 virtual/composite-after-paint/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html [ Timeout ] crbug.com/901056 virtual/composite-after-paint/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html [ Timeout ]
### virtual/sxg-subresource/external/wpt/signed-exchange/subresource/ ### external/wpt/signed-exchange/subresource/
crbug.com/901056 virtual/sxg-subresource/external/wpt/signed-exchange/subresource/sxg-subresource.tentative.html [ Timeout ] crbug.com/901056 external/wpt/signed-exchange/subresource/sxg-subresource.tentative.html [ Timeout ]
### http/tests/devtools/sources/debugger/ ### http/tests/devtools/sources/debugger/
crbug.com/1063051 http/tests/devtools/sources/debugger/debug-inlined-scripts-fragment-id.js [ Timeout ] crbug.com/1063051 http/tests/devtools/sources/debugger/debug-inlined-scripts-fragment-id.js [ Timeout ]
......
...@@ -2148,6 +2148,10 @@ virtual/wbn-from-network/external/wpt/web-bundle/wbn-from-network/* [ Pass ] ...@@ -2148,6 +2148,10 @@ virtual/wbn-from-network/external/wpt/web-bundle/wbn-from-network/* [ Pass ]
crbug.com/1082020 http/tests/loading/wbn/origin-trial/* [ Skip ] crbug.com/1082020 http/tests/loading/wbn/origin-trial/* [ Skip ]
virtual/subresource-web-bundles-disabled/http/tests/loading/wbn/origin-trial/* [ Pass ] virtual/subresource-web-bundles-disabled/http/tests/loading/wbn/origin-trial/* [ Pass ]
# This test requires sxg-subresource-disabled.
http/tests/loading/sxg/sxg-subresource-origin-trial.https.html [ Skip ]
virtual/sxg-subresource-disabled/http/tests/loading/sxg/sxg-subresource-origin-trial.https.html [ Pass ]
# No good way to automate this test yet # No good way to automate this test yet
external/wpt/native-file-system/showSaveFilePicker-manual.https.html [ Skip ] external/wpt/native-file-system/showSaveFilePicker-manual.https.html [ Skip ]
......
...@@ -377,9 +377,9 @@ ...@@ -377,9 +377,9 @@
"args": ["--autoplay-policy=document-user-activation-required"] "args": ["--autoplay-policy=document-user-activation-required"]
}, },
{ {
"prefix": "sxg-subresource", "prefix": "sxg-subresource-disabled",
"bases": ["external/wpt/signed-exchange"], "bases": ["http/tests/loading/sxg/sxg-subresource-origin-trial.https.html"],
"args": ["--enable-features=SignedExchangeSubresourcePrefetch"] "args": ["--disable-blink-features=SignedExchangeSubresourcePrefetch"]
}, },
{ {
"prefix": "wbn-from-network", "prefix": "wbn-from-network",
......
This is a testharness.js-based test.
FAIL Subresource signed exchange prefetch. assert_equals: expected "from server" but got "sxg-subresource-script.js should not be prefetched"
Harness: the test ran to completion.
This is a testharness.js-based test.
FAIL Subresource signed exchange prefetch. assert_equals: expected "from signed exchange" but got "sxg-subresource-script.js should not be prefetched"
Harness: the test ran to completion.
With --disable-features=SignedExchangeSubresourcePrefetch
This directory is for testing the SignedExchangeSubresourcePrefetch feature.
This is a testharness.js-based test.
PASS Subresource signed exchange prefetch.
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS Subresource signed exchange prefetch.
Harness: the test ran to completion.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment