Commit 88cb4047 authored by Nico Weber's avatar Nico Weber

Work more on getting things built with -Wimplicit-fallthrough.

This CL was uploaded by git cl split.

R=eae@chromium.org

Bug: 177475
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I3a861bf5eb39da51b628eafae99d0bff3ebfab39
Reviewed-on: https://chromium-review.googlesource.com/889728Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532255}
parent 2ed20c91
...@@ -493,7 +493,7 @@ NGInlineLayoutStateStack::ApplyBaselineShift( ...@@ -493,7 +493,7 @@ NGInlineLayoutStateStack::ApplyBaselineShift(
break; break;
} }
NOTREACHED(); NOTREACHED();
// Fall through. FALLTHROUGH;
case EVerticalAlign::kBottom: case EVerticalAlign::kBottom:
if (box->metrics.IsEmpty()) if (box->metrics.IsEmpty())
baseline_shift = -child.metrics.descent; baseline_shift = -child.metrics.descent;
......
...@@ -61,7 +61,7 @@ inline int FragmentainerBreakPrecedence(EBreakBetween break_value) { ...@@ -61,7 +61,7 @@ inline int FragmentainerBreakPrecedence(EBreakBetween break_value) {
switch (break_value) { switch (break_value) {
default: default:
NOTREACHED(); NOTREACHED();
// fall-through FALLTHROUGH;
case EBreakBetween::kAuto: case EBreakBetween::kAuto:
return 0; return 0;
case EBreakBetween::kAvoidColumn: case EBreakBetween::kAvoidColumn:
......
...@@ -117,6 +117,7 @@ LayoutUnit ResolveInlineLength(const NGConstraintSpace& constraint_space, ...@@ -117,6 +117,7 @@ LayoutUnit ResolveInlineLength(const NGConstraintSpace& constraint_space,
case kDeviceHeight: case kDeviceHeight:
case kExtendToZoom: case kExtendToZoom:
NOTREACHED() << "These should only be used for viewport definitions"; NOTREACHED() << "These should only be used for viewport definitions";
FALLTHROUGH;
case kMaxSizeNone: case kMaxSizeNone:
default: default:
NOTREACHED(); NOTREACHED();
...@@ -193,6 +194,7 @@ LayoutUnit ResolveBlockLength(const NGConstraintSpace& constraint_space, ...@@ -193,6 +194,7 @@ LayoutUnit ResolveBlockLength(const NGConstraintSpace& constraint_space,
case kDeviceHeight: case kDeviceHeight:
case kExtendToZoom: case kExtendToZoom:
NOTREACHED() << "These should only be used for viewport definitions"; NOTREACHED() << "These should only be used for viewport definitions";
FALLTHROUGH;
case kMaxSizeNone: case kMaxSizeNone:
default: default:
NOTREACHED(); NOTREACHED();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment