Remove platform/probe

No one uses it.

Bug: 914739
Change-Id: I34d0211d4f9ca1edc475de653cfbecb077e45bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619524Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664655}

third_party/blink/renderer/core/probe/core_probes.cc

@@ -47,6 +47,23 @@ void* AsyncId(void* task) {
 }
 }  // namespace
 
+TimeTicks ProbeBase::CaptureStartTime() const {
+  if (start_time_.is_null())
+    start_time_ = CurrentTimeTicks();
+  return start_time_;
+}
+
+TimeTicks ProbeBase::CaptureEndTime() const {
+  if (end_time_.is_null())
+    end_time_ = CurrentTimeTicks();
+  return end_time_;
+}
+
+TimeDelta ProbeBase::Duration() const {
+  DCHECK(!start_time_.is_null());
+  return CaptureEndTime() - start_time_;
+}
+
 AsyncTask::AsyncTask(ExecutionContext* context,
                      void* task,
                      const char* step,

third_party/blink/renderer/core/probe/core_probes.h

@@ -35,7 +35,6 @@
 #include "third_party/blink/renderer/core/dom/document.h"
 #include "third_party/blink/renderer/core/frame/local_frame.h"
 #include "third_party/blink/renderer/platform/loader/fetch/resource.h"
-#include "third_party/blink/renderer/platform/probe/platform_probes.h"
 
 namespace network {
 namespace mojom {
@@ -53,6 +52,19 @@ class ThreadDebugger;
 
 namespace probe {
 
+class CORE_EXPORT ProbeBase {
+  STACK_ALLOCATED();
+
+ public:
+  TimeTicks CaptureStartTime() const;
+  TimeTicks CaptureEndTime() const;
+  TimeDelta Duration() const;
+
+ private:
+  mutable TimeTicks start_time_;
+  mutable TimeTicks end_time_;
+};
+
 class CORE_EXPORT AsyncTask {
   STACK_ALLOCATED();
 

third_party/blink/renderer/platform/BUILD.gn

@@ -99,33 +99,6 @@ compiled_action("character_data") {
   args = rebase_path(outputs, root_build_dir)
 }
 
-action("instrumentation_probes") {
-  script = "../build/scripts/make_instrumenting_probes.py"
-
-  input_file = "probe/platform_probes.pidl"
-  inputs = [
-    input_file,
-    "probe/platform_probes.json5",
-    "../build/scripts/templates/instrumenting_probes_impl.cc.tmpl",
-    "../build/scripts/templates/instrumenting_probes_inl.h.tmpl",
-    "../build/scripts/templates/probe_sink.h.tmpl",
-  ]
-
-  outputs = [
-    "$blink_platform_output_dir/platform_probe_sink.h",
-    "$blink_platform_output_dir/platform_probes_impl.cc",
-    "$blink_platform_output_dir/platform_probes_inl.h",
-  ]
-
-  args = [
-    rebase_path(inputs[0], root_build_dir),
-    "--config",
-    rebase_path("probe/platform_probes.json5", root_build_dir),
-    "--output_dir",
-    rebase_path(blink_platform_output_dir, root_build_dir),
-  ]
-}
-
 executable("character_data_generator") {
   sources = [
     "text/character_property_data.h",
@@ -149,7 +122,6 @@ group("make_platform_generated") {
     ":character_data",
     ":color_data",
     ":font_family_names",
-    ":instrumentation_probes",
     ":runtime_enabled_features",
     "//third_party/blink/renderer/platform/network:make_generated",
   ]
@@ -1257,10 +1229,6 @@ jumbo_component("platform") {
     "prerender.cc",
     "prerender.h",
     "prerender_client.h",
-    "probe/platform_probes.cc",
-    "probe/platform_probes.h",
-    "probe/platform_trace_events_agent.cc",
-    "probe/platform_trace_events_agent.h",
     "resolution_units.h",
     "shared_buffer.cc",
     "shared_buffer.h",
@@ -1402,8 +1370,7 @@ jumbo_component("platform") {
   # Add in the generated files.
   sources += get_target_outputs(":character_data") +
              get_target_outputs(":color_data") +
-             get_target_outputs(":font_family_names") +
-             get_target_outputs(":instrumentation_probes")
+             get_target_outputs(":font_family_names")
   set_sources_assignment_filter([ "*.pickle" ])
   sources += get_target_outputs(":runtime_enabled_features")
   set_sources_assignment_filter(sources_assignment_filter)

third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc

@@ -64,7 +64,6 @@
 #include "third_party/blink/renderer/platform/mhtml/mhtml_archive.h"
 #include "third_party/blink/renderer/platform/network/encoded_form_data.h"
 #include "third_party/blink/renderer/platform/network/network_utils.h"
-#include "third_party/blink/renderer/platform/probe/platform_probes.h"
 #include "third_party/blink/renderer/platform/runtime_enabled_features.h"
 #include "third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h"
 #include "third_party/blink/renderer/platform/weborigin/known_ports.h"

third_party/blink/renderer/platform/probe/DEPS

-include_rules = [
-    # Don't depend on platform/.
-    "-third_party/blink/renderer/platform",
-
-    # Module.
-    "+third_party/blink/renderer/platform/probe",
-
-    # Dependencies.
-    "+third_party/blink/renderer/platform/heap",
-    "+third_party/blink/renderer/platform/instrumentation",
-    "+third_party/blink/renderer/platform/loader/fetch/fetch_context.h",
-    "+third_party/blink/renderer/platform/platform_export.h",
-    "+third_party/blink/renderer/platform/platform_probes_inl.h",
-    "+third_party/blink/renderer/platform/wtf",
-]

third_party/blink/renderer/platform/probe/OWNERS

-alph@chromium.org
-caseq@chromium.org

third_party/blink/renderer/platform/probe/platform_probes.cc

-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "third_party/blink/renderer/platform/probe/platform_probes.h"
-
-namespace blink {
-namespace probe {
-
-TimeTicks ProbeBase::CaptureStartTime() const {
-  if (start_time_.is_null())
-    start_time_ = CurrentTimeTicks();
-  return start_time_;
-}
-
-TimeTicks ProbeBase::CaptureEndTime() const {
-  if (end_time_.is_null())
-    end_time_ = CurrentTimeTicks();
-  return end_time_;
-}
-
-TimeDelta ProbeBase::Duration() const {
-  DCHECK(!start_time_.is_null());
-  return CaptureEndTime() - start_time_;
-}
-
-}  // namespace probe
-}  // namespace blink

third_party/blink/renderer/platform/probe/platform_probes.h

-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef THIRD_PARTY_BLINK_RENDERER_PLATFORM_PROBE_PLATFORM_PROBES_H_
-#define THIRD_PARTY_BLINK_RENDERER_PLATFORM_PROBE_PLATFORM_PROBES_H_
-
-#include "third_party/blink/renderer/platform/platform_export.h"
-#include "third_party/blink/renderer/platform/wtf/allocator.h"
-#include "third_party/blink/renderer/platform/wtf/time.h"
-
-namespace blink {
-
-namespace probe {
-
-class PLATFORM_EXPORT ProbeBase {
-  STACK_ALLOCATED();
-
- public:
-  TimeTicks CaptureStartTime() const;
-  TimeTicks CaptureEndTime() const;
-  TimeDelta Duration() const;
-
- private:
-  mutable TimeTicks start_time_;
-  mutable TimeTicks end_time_;
-};
-
-}  // namespace probe
-}  // namespace blink
-
-#include "third_party/blink/renderer/platform/platform_probes_inl.h"
-
-#endif  // THIRD_PARTY_BLINK_RENDERER_PLATFORM_PROBE_PLATFORM_PROBES_H_

third_party/blink/renderer/platform/probe/platform_probes.json5

-{
-  settings: {
-    export_header: "third_party/blink/renderer/platform/platform_export.h",
-    export_symbol: "PLATFORM_EXPORT",
-    include_path: "third_party/blink/renderer/platform/probe",
-    includes: [
-      "third_party/blink/renderer/platform/platform_probe_sink.h",
-      "third_party/blink/renderer/platform/probe/platform_probes.h",
-    ]
-  },
-  observers: {
-  }
-}

third_party/blink/renderer/platform/probe/platform_probes.pidl

-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-interface PlatformProbes {
-}

third_party/blink/renderer/platform/probe/platform_trace_events_agent.cc

-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "third_party/blink/renderer/platform/probe/platform_trace_events_agent.h"
-
-#include "third_party/blink/renderer/platform/instrumentation/tracing/trace_event.h"
-#include "third_party/blink/renderer/platform/instrumentation/tracing/traced_value.h"
-#include "third_party/blink/renderer/platform/probe/platform_probes.h"
-
-namespace blink {
-
-namespace {
-
-}  // namespace
-
-void PlatformTraceEventsAgent::Will(const probe::PlatformSendRequest& probe) {
-}
-
-void PlatformTraceEventsAgent::Did(const probe::PlatformSendRequest& probe) {
-}
-
-}  // namespace blink

third_party/blink/renderer/platform/probe/platform_trace_events_agent.h

-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef THIRD_PARTY_BLINK_RENDERER_PLATFORM_PROBE_PLATFORM_TRACE_EVENTS_AGENT_H_
-#define THIRD_PARTY_BLINK_RENDERER_PLATFORM_PROBE_PLATFORM_TRACE_EVENTS_AGENT_H_
-
-#include "third_party/blink/renderer/platform/heap/heap.h"
-#include "third_party/blink/renderer/platform/platform_export.h"
-
-namespace blink {
-
-namespace probe {
-class PlatformSendRequest;
-}
-
-class PLATFORM_EXPORT PlatformTraceEventsAgent
-    : public GarbageCollected<PlatformTraceEventsAgent> {
- public:
-  void Trace(blink::Visitor* visitor) {}
-
-  void Will(const probe::PlatformSendRequest&);
-  void Did(const probe::PlatformSendRequest&);
-};
-
-}  // namespace blink
-
-#endif  // THIRD_PARTY_BLINK_RENDERER_PLATFORM_PROBE_PLATFORM_TRACE_EVENTS_AGENT_H_