Commit 88d01648 authored by dglazkov@chromium.org's avatar dglazkov@chromium.org

2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * page/chromium/ChromeClientChromium.h:
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * public/WebViewClient.h:
        * src/ChromeClientImpl.cpp:
        * src/ChromeClientImpl.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54466 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 204f7105
2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* page/chromium/ChromeClientChromium.h:
2010-02-06 Dimitri Glazkov <dglazkov@chromium.org> 2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth. Reviewed by Adam Barth.
......
...@@ -26,22 +26,11 @@ ...@@ -26,22 +26,11 @@
#include "config.h" #include "config.h"
#include "AXObjectCache.h" #include "AXObjectCache.h"
#include "AccessibilityObject.h" #include "AccessibilityObject.h"
#include "Chrome.h"
#include "ChromeClientChromium.h"
#include "FrameView.h"
namespace WebCore { namespace WebCore {
static ChromeClientChromium* toChromeClientChromium(FrameView* view)
{
Page* page = view->frame() ? view->frame()->page() : 0;
if (!page)
return 0;
return static_cast<ChromeClientChromium*>(page->chrome()->client());
}
void AXObjectCache::detachWrapper(AccessibilityObject* obj) void AXObjectCache::detachWrapper(AccessibilityObject* obj)
{ {
// In Chromium, AccessibilityObjects are wrapped lazily. // In Chromium, AccessibilityObjects are wrapped lazily.
...@@ -54,14 +43,8 @@ void AXObjectCache::attachWrapper(AccessibilityObject*) ...@@ -54,14 +43,8 @@ void AXObjectCache::attachWrapper(AccessibilityObject*)
// In Chromium, AccessibilityObjects are wrapped lazily. // In Chromium, AccessibilityObjects are wrapped lazily.
} }
void AXObjectCache::postPlatformNotification(AccessibilityObject* obj, AXNotification notification) void AXObjectCache::postPlatformNotification(AccessibilityObject*, AXNotification)
{ {
if (!obj || !obj->documentFrameView() || notification != AXCheckedStateChanged)
return;
ChromeClientChromium* client = toChromeClientChromium(obj->documentFrameView());
if (client)
client->didChangeAccessibilityObjectState(obj);
} }
void AXObjectCache::handleFocusedUIElementChanged(RenderObject*, RenderObject*) void AXObjectCache::handleFocusedUIElementChanged(RenderObject*, RenderObject*)
......
...@@ -35,25 +35,20 @@ ...@@ -35,25 +35,20 @@
#include <wtf/Forward.h> #include <wtf/Forward.h>
namespace WebCore { namespace WebCore {
class IntRect;
class PopupContainer;
class AccessibilityObject; // Contains Chromium-specific extensions to the ChromeClient. Only put
class IntRect; // things here that don't make sense for other ports.
class PopupContainer; class ChromeClientChromium : public ChromeClient {
public:
// Contains Chromium-specific extensions to the ChromeClient. Only put
// things here that don't make sense for other ports.
class ChromeClientChromium : public ChromeClient {
public:
// Notifies the client of a new popup widget. The client should place // Notifies the client of a new popup widget. The client should place
// and size the widget with the given bounds, relative to the screen. // and size the widget with the given bounds, relative to the screen.
// If handleExternal is true, then drawing and input handling for the // If handleExternal is true, then drawing and input handling for the
// popup will be handled by the external embedder. // popup will be handled by the external embedder.
virtual void popupOpened(PopupContainer* popupContainer, const IntRect& bounds, virtual void popupOpened(PopupContainer* popupContainer, const IntRect& bounds,
bool focusOnShow, bool handleExternal) = 0; bool focusOnShow, bool handleExternal) = 0;
};
// Notifies embedder that the state of an accessibility object has changed.
virtual void didChangeAccessibilityObjectState(AccessibilityObject*) = 0;
};
} // namespace WebCore } // namespace WebCore
......
2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
* public/WebViewClient.h:
* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:
2010-02-05 James Hawkins <jhawkins@chromium.org> 2010-02-05 James Hawkins <jhawkins@chromium.org>
Reviewed by David Levin. Reviewed by David Levin.
......
...@@ -252,9 +252,6 @@ public: ...@@ -252,9 +252,6 @@ public:
// accessibility object. // accessibility object.
virtual void focusAccessibilityObject(const WebAccessibilityObject&) { } virtual void focusAccessibilityObject(const WebAccessibilityObject&) { }
// Notifies embedder that the state of an accessibility object has changed.
virtual void didChangeAccessibilityObjectState(const WebAccessibilityObject&) { }
// Developer tools ----------------------------------------------------- // Developer tools -----------------------------------------------------
......
...@@ -659,13 +659,6 @@ void ChromeClientImpl::getPopupMenuInfo(PopupContainer* popupContainer, ...@@ -659,13 +659,6 @@ void ChromeClientImpl::getPopupMenuInfo(PopupContainer* popupContainer,
info->items.swap(outputItems); info->items.swap(outputItems);
} }
void ChromeClientImpl::didChangeAccessibilityObjectState(AccessibilityObject* obj)
{
// Alert assistive technology about the accessibility object state change
if (obj)
m_webView->client()->didChangeAccessibilityObjectState(WebAccessibilityObject(obj));
}
#if ENABLE(NOTIFICATIONS) #if ENABLE(NOTIFICATIONS)
NotificationPresenter* ChromeClientImpl::notificationPresenter() const NotificationPresenter* ChromeClientImpl::notificationPresenter() const
{ {
......
...@@ -34,7 +34,6 @@ ...@@ -34,7 +34,6 @@
#include "ChromeClientChromium.h" #include "ChromeClientChromium.h"
namespace WebCore { namespace WebCore {
class AccessibilityObject;
class HTMLParserQuirks; class HTMLParserQuirks;
class PopupContainer; class PopupContainer;
class SecurityOrigin; class SecurityOrigin;
...@@ -133,7 +132,6 @@ public: ...@@ -133,7 +132,6 @@ public:
const WebCore::IntRect& bounds, const WebCore::IntRect& bounds,
bool activatable, bool activatable,
bool handleExternally); bool handleExternally);
virtual void didChangeAccessibilityObjectState(WebCore::AccessibilityObject*);
// ChromeClientImpl: // ChromeClientImpl:
void setCursor(const WebCursorInfo& cursor); void setCursor(const WebCursorInfo& cursor);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment