2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * page/chromium/ChromeClientChromium.h:
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * public/WebViewClient.h:
        * src/ChromeClientImpl.cpp:
        * src/ChromeClientImpl.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/WebCore/ChangeLog

+2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        No review, rolling out r54364.
+        http://trac.webkit.org/changeset/54364
+        https://bugs.webkit.org/show_bug.cgi?id=34464
+
+        Introduced asserts in layout tests, needs more testing
+        locally.
+
+        * accessibility/chromium/AXObjectCacheChromium.cpp:
+        (WebCore::AXObjectCache::postPlatformNotification):
+        * page/chromium/ChromeClientChromium.h:
+
 2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>
 
         Reviewed by Adam Barth.

third_party/WebKit/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp

@@ -26,22 +26,11 @@
 
 #include "config.h"
 #include "AXObjectCache.h"
+
 #include "AccessibilityObject.h"
-#include "Chrome.h"
-#include "ChromeClientChromium.h"
-#include "FrameView.h"
 
 namespace WebCore {
 
-static ChromeClientChromium* toChromeClientChromium(FrameView* view)
-{
-    Page* page = view->frame() ? view->frame()->page() : 0;
-    if (!page)
-        return 0;
-
-    return static_cast<ChromeClientChromium*>(page->chrome()->client());
-}
-
 void AXObjectCache::detachWrapper(AccessibilityObject* obj)
 {
     // In Chromium, AccessibilityObjects are wrapped lazily.
@@ -54,14 +43,8 @@ void AXObjectCache::attachWrapper(AccessibilityObject*)
     // In Chromium, AccessibilityObjects are wrapped lazily.
 }
 
-void AXObjectCache::postPlatformNotification(AccessibilityObject* obj, AXNotification notification)
+void AXObjectCache::postPlatformNotification(AccessibilityObject*, AXNotification)
 {
-    if (!obj || !obj->documentFrameView() || notification != AXCheckedStateChanged)
-        return;
-
-    ChromeClientChromium* client = toChromeClientChromium(obj->documentFrameView());
-    if (client)
-        client->didChangeAccessibilityObjectState(obj);
 }
 
 void AXObjectCache::handleFocusedUIElementChanged(RenderObject*, RenderObject*)

third_party/WebKit/WebCore/page/chromium/ChromeClientChromium.h

@@ -35,25 +35,20 @@
 #include <wtf/Forward.h>
 
 namespace WebCore {
-
-class AccessibilityObject;
-class IntRect;
-class PopupContainer;
-
-// Contains Chromium-specific extensions to the ChromeClient.  Only put
-// things here that don't make sense for other ports.
-class ChromeClientChromium : public ChromeClient {
-public:
-    // Notifies the client of a new popup widget.  The client should place
-    // and size the widget with the given bounds, relative to the screen.
-    // If handleExternal is true, then drawing and input handling for the
-    // popup will be handled by the external embedder.
-    virtual void popupOpened(PopupContainer* popupContainer, const IntRect& bounds,
-                             bool focusOnShow, bool handleExternal) = 0;
-
-    // Notifies embedder that the state of an accessibility object has changed.
-    virtual void didChangeAccessibilityObjectState(AccessibilityObject*) = 0;
-};
+    class IntRect;
+    class PopupContainer;
+
+    // Contains Chromium-specific extensions to the ChromeClient.  Only put
+    // things here that don't make sense for other ports.
+    class ChromeClientChromium : public ChromeClient {
+    public:
+        // Notifies the client of a new popup widget.  The client should place
+        // and size the widget with the given bounds, relative to the screen.
+        // If handleExternal is true, then drawing and input handling for the
+        // popup will be handled by the external embedder.
+        virtual void popupOpened(PopupContainer* popupContainer, const IntRect& bounds,
+                                 bool focusOnShow, bool handleExternal) = 0;
+    };
 
 } // namespace WebCore
 

third_party/WebKit/WebKit/chromium/ChangeLog

+2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        No review, rolling out r54364.
+        http://trac.webkit.org/changeset/54364
+        https://bugs.webkit.org/show_bug.cgi?id=34464
+
+        Introduced asserts in layout tests, needs more testing
+        locally.
+
+        * public/WebViewClient.h:
+        * src/ChromeClientImpl.cpp:
+        * src/ChromeClientImpl.h:
+
 2010-02-05  James Hawkins  <jhawkins@chromium.org>
 
         Reviewed by David Levin.

third_party/WebKit/WebKit/chromium/public/WebViewClient.h

@@ -252,9 +252,6 @@ public:
     // accessibility object.
     virtual void focusAccessibilityObject(const WebAccessibilityObject&) { }
 
-    // Notifies embedder that the state of an accessibility object has changed.
-    virtual void didChangeAccessibilityObjectState(const WebAccessibilityObject&) { }
-
 
     // Developer tools -----------------------------------------------------
 

third_party/WebKit/WebKit/chromium/src/ChromeClientImpl.cpp

@@ -659,13 +659,6 @@ void ChromeClientImpl::getPopupMenuInfo(PopupContainer* popupContainer,
     info->items.swap(outputItems);
 }
 
-void ChromeClientImpl::didChangeAccessibilityObjectState(AccessibilityObject* obj)
-{
-    // Alert assistive technology about the accessibility object state change
-    if (obj)
-        m_webView->client()->didChangeAccessibilityObjectState(WebAccessibilityObject(obj));
-}
-
 #if ENABLE(NOTIFICATIONS)
 NotificationPresenter* ChromeClientImpl::notificationPresenter() const
 {

third_party/WebKit/WebKit/chromium/src/ChromeClientImpl.h

@@ -34,7 +34,6 @@
 #include "ChromeClientChromium.h"
 
 namespace WebCore {
-class AccessibilityObject;
 class HTMLParserQuirks;
 class PopupContainer;
 class SecurityOrigin;
@@ -133,7 +132,6 @@ public:
                              const WebCore::IntRect& bounds,
                              bool activatable,
                              bool handleExternally);
-    virtual void didChangeAccessibilityObjectState(WebCore::AccessibilityObject*);
 
     // ChromeClientImpl:
     void setCursor(const WebCursorInfo& cursor);