Commit 88d37d7e authored by Amy Qiu's avatar Amy Qiu Committed by Commit Bot

Add tags to filter by page set

Add tags to all pages in each page set to enable filtering results by different page
sets.

Bug: 849392
Change-Id: Icf6a97566925de783b81cf2f4cb71f3d68f11971
Reviewed-on: https://chromium-review.googlesource.com/1093012
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567659}
parent 45ed56cd
...@@ -6,6 +6,7 @@ from telemetry import story ...@@ -6,6 +6,7 @@ from telemetry import story
from page_sets.login_helpers import google_login from page_sets.login_helpers import google_login
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
from page_sets.system_health import platforms from page_sets.system_health import platforms
...@@ -13,6 +14,7 @@ class KeyDesktopMoveCasesPage(rendering_story.RenderingStory): ...@@ -13,6 +14,7 @@ class KeyDesktopMoveCasesPage(rendering_story.RenderingStory):
"""Abstract base class for key desktop move cases pages.""" """Abstract base class for key desktop move cases pages."""
ABSTRACT_STORY = True ABSTRACT_STORY = True
SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
TAGS = [story_tags.KEY_DESKTOP_MOVE]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -6,6 +6,7 @@ from telemetry import story ...@@ -6,6 +6,7 @@ from telemetry import story
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.system_health import platforms from page_sets.system_health import platforms
from page_sets.rendering import story_tags
class KeySilkPage(rendering_story.RenderingStory): class KeySilkPage(rendering_story.RenderingStory):
...@@ -13,6 +14,7 @@ class KeySilkPage(rendering_story.RenderingStory): ...@@ -13,6 +14,7 @@ class KeySilkPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
TAGS = [story_tags.KEY_SILK]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -28,7 +28,7 @@ class MapsPage(rendering_story.RenderingStory): ...@@ -28,7 +28,7 @@ class MapsPage(rendering_story.RenderingStory):
""" """
BASE_NAME = 'maps_perf_test' BASE_NAME = 'maps_perf_test'
URL = 'file://performance.html' URL = 'file://performance.html'
TAGS = [story_tags.REQUIRED_WEBGL] TAGS = [story_tags.REQUIRED_WEBGL, story_tags.MAPS]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -5,12 +5,14 @@ from telemetry.page import shared_page_state ...@@ -5,12 +5,14 @@ from telemetry.page import shared_page_state
from telemetry import story from telemetry import story
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
from page_sets.system_health import platforms from page_sets.system_health import platforms
class PathologicalMobileSitesPage(rendering_story.RenderingStory): class PathologicalMobileSitesPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
TAGS = [story_tags.PATHOLOGICAL_MOBILE_SITES]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -5,6 +5,7 @@ from telemetry.page import shared_page_state ...@@ -5,6 +5,7 @@ from telemetry.page import shared_page_state
from telemetry.util import js_template from telemetry.util import js_template
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
from page_sets.system_health import platforms from page_sets.system_health import platforms
...@@ -17,6 +18,7 @@ class PolymerPage(rendering_story.RenderingStory): ...@@ -17,6 +18,7 @@ class PolymerPage(rendering_story.RenderingStory):
""" """
ABSTRACT_STORY = True ABSTRACT_STORY = True
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
TAGS = [story_tags.POLYMER]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -9,7 +9,7 @@ from telemetry.page import shared_page_state ...@@ -9,7 +9,7 @@ from telemetry.page import shared_page_state
class RenderingSharedState(shared_page_state.SharedPageState): class RenderingSharedState(shared_page_state.SharedPageState):
def CanRunOnBrowser(self, browser_info, page): def CanRunOnBrowser(self, browser_info, page):
if page.TAGS and story_tags.PINCH_ZOOM in page.TAGS: if page.TAGS and story_tags.TOUGH_PINCH_ZOOM in page.TAGS:
os_name = self.platform.GetOSName() os_name = self.platform.GetOSName()
if os_name == 'linux' or os_name == 'win': if os_name == 'linux' or os_name == 'win':
logging.warning('Pinch zoom pages only for Mac, skipping test') logging.warning('Pinch zoom pages only for Mac, skipping test')
......
...@@ -5,12 +5,14 @@ from telemetry.page import shared_page_state ...@@ -5,12 +5,14 @@ from telemetry.page import shared_page_state
from telemetry import story from telemetry import story
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
from page_sets.system_health import platforms from page_sets.system_health import platforms
class SimplePage(rendering_story.RenderingStory): class SimplePage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
TAGS = [story_tags.SIMPLE_MOBILE_SITES]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -19,10 +19,47 @@ FASTPATH = Tag( ...@@ -19,10 +19,47 @@ FASTPATH = Tag(
'fastpath', 'Fast path stories.') 'fastpath', 'Fast path stories.')
REQUIRED_WEBGL = Tag( REQUIRED_WEBGL = Tag(
'required_webgl', 'Stories that are skipped if no webgl support') 'required_webgl', 'Stories that are skipped if no webgl support')
PINCH_ZOOM = Tag(
'pinch_zoom', 'Stories that only run on Mac for desktop cases') # Below are tags for filtering by page sets
IMAGE_DECODING = Tag( IMAGE_DECODING = Tag(
'image_decoding', 'Stories with accelerated jpeg decoding') 'image_decoding', 'Stories with accelerated jpeg decoding')
KEY_DESKTOP_MOVE = Tag(
'key_desktop_move', 'Key desktop move stories')
KEY_SILK = Tag(
'key_silk', 'Key silk stories')
MAPS = Tag(
'maps', 'Maps stories')
PATHOLOGICAL_MOBILE_SITES = Tag(
'pathological_mobile_sites', 'Pathological mobile sites')
POLYMER = Tag(
'polymer', 'Polymer stories')
SIMPLE_MOBILE_SITES = Tag(
'simple_mobile_sites', 'Simple mobile sites')
TOP_REAL_WORLD_DESKTOP = Tag(
'top_real_world_desktop', 'Top real world desktop stories')
TOP_REAL_WORLD_MOBILE = Tag(
'top_real_world_mobile', 'Top real world mobile stories')
TOUGH_ANIMATION = Tag(
'tough_animation', 'Tough animation stories')
TOUGH_CANVAS = Tag(
'tough_canvas', 'Tough canvas stories')
TOUGH_FILTERS = Tag(
'tough_filters', 'Tough filters stories')
TOUGH_IMAGE_DECODE = Tag(
'tough_image_decode', 'Tough image decode stories')
TOUGH_PATH_RENDERING = Tag(
'tough_path_rendering', 'Tough path rendering stories')
TOUGH_PINCH_ZOOM = Tag(
'tough_pinch_zoom', 'Tough pinch zoom stories (only on Mac for desktop)')
TOUGH_SCHEDULING = Tag(
'tough_scheduling', 'Tough scheduling stories')
TOUGH_SCROLLING = Tag(
'tough_scrolling', 'Tough scrolling stories')
TOUGH_TEXTURE_UPLOAD = Tag(
'tough_texture_upload', 'Tough texture upload stories')
TOUGH_WEBGL = Tag(
'tough_webgl', 'Tough webgl stories')
def _ExtractAllTags(): def _ExtractAllTags():
......
...@@ -10,7 +10,7 @@ from page_sets.rendering import story_tags ...@@ -10,7 +10,7 @@ from page_sets.rendering import story_tags
class TopRealWorldDesktopPage(rendering_story.RenderingStory): class TopRealWorldDesktopPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
TAGS = [story_tags.GPU_RASTERIZATION] TAGS = [story_tags.GPU_RASTERIZATION, story_tags.TOP_REAL_WORLD_DESKTOP]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -10,7 +10,7 @@ from page_sets.system_health import platforms ...@@ -10,7 +10,7 @@ from page_sets.system_health import platforms
class TopRealWorldMobilePage(rendering_story.RenderingStory): class TopRealWorldMobilePage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
TAGS = [story_tags.SYNC_SCROLL] TAGS = [story_tags.SYNC_SCROLL, story_tags.TOP_REAL_WORLD_MOBILE]
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
def __init__(self, def __init__(self,
......
...@@ -5,11 +5,13 @@ from telemetry.page import shared_page_state ...@@ -5,11 +5,13 @@ from telemetry.page import shared_page_state
from telemetry import story from telemetry import story
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
class ToughAnimationPage(rendering_story.RenderingStory): class ToughAnimationPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
NEED_MEASUREMENT_READY = True NEED_MEASUREMENT_READY = True
TAGS = [story_tags.TOUGH_ANIMATION]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -5,10 +5,12 @@ from telemetry import story ...@@ -5,10 +5,12 @@ from telemetry import story
from telemetry.page import shared_page_state from telemetry.page import shared_page_state
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
class ToughCanvasPage(rendering_story.RenderingStory): class ToughCanvasPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
TAGS = [story_tags.TOUGH_CANVAS]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -5,9 +5,12 @@ from telemetry.page import shared_page_state ...@@ -5,9 +5,12 @@ from telemetry.page import shared_page_state
from telemetry import story from telemetry import story
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
class ToughFiltersCasesPage(rendering_story.RenderingStory): class ToughFiltersCasesPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
TAGS = [story_tags.TOUGH_FILTERS]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -5,10 +5,12 @@ from telemetry.page import shared_page_state ...@@ -5,10 +5,12 @@ from telemetry.page import shared_page_state
from telemetry import story from telemetry import story
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
class ToughImageDecodePage(rendering_story.RenderingStory): class ToughImageDecodePage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
TAGS = [story_tags.TOUGH_IMAGE_DECODE]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -5,10 +5,12 @@ from telemetry.page import shared_page_state ...@@ -5,10 +5,12 @@ from telemetry.page import shared_page_state
from telemetry import story from telemetry import story
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
class ToughPathRenderingPage(rendering_story.RenderingStory): class ToughPathRenderingPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
TAGS = [story_tags.TOUGH_PATH_RENDERING]
def RunPageInteractions(self, action_runner): def RunPageInteractions(self, action_runner):
with action_runner.CreateInteraction('ClickStart'): with action_runner.CreateInteraction('ClickStart'):
...@@ -35,6 +37,7 @@ class MotionMarkCanvasStrokeShapesPage(ToughPathRenderingPage): ...@@ -35,6 +37,7 @@ class MotionMarkCanvasStrokeShapesPage(ToughPathRenderingPage):
class ChalkboardPage(rendering_story.RenderingStory): class ChalkboardPage(rendering_story.RenderingStory):
BASE_NAME = 'ie_chalkboard' BASE_NAME = 'ie_chalkboard'
URL = 'https://testdrive-archive.azurewebsites.net/performance/chalkboard/' URL = 'https://testdrive-archive.azurewebsites.net/performance/chalkboard/'
TAGS = [story_tags.TOUGH_PATH_RENDERING]
def RunPageInteractions(self, action_runner): def RunPageInteractions(self, action_runner):
with action_runner.CreateInteraction('ClickStart'): with action_runner.CreateInteraction('ClickStart'):
......
...@@ -11,9 +11,9 @@ from page_sets.system_health import platforms ...@@ -11,9 +11,9 @@ from page_sets.system_health import platforms
class ToughPinchZoomPage(rendering_story.RenderingStory): class ToughPinchZoomPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
TAGS = [story_tags.GPU_RASTERIZATION, story_tags.PINCH_ZOOM] # TODO(crbug.com/851499): expand supported_platforms to both desktop & mobile
# TODO(crbug.com/852373): expand supported_platforms to both desktop & mobile
SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
TAGS = [story_tags.GPU_RASTERIZATION, story_tags.TOUGH_PINCH_ZOOM]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -5,10 +5,12 @@ from telemetry.page import shared_page_state ...@@ -5,10 +5,12 @@ from telemetry.page import shared_page_state
from telemetry import story from telemetry import story
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
class ToughSchedulingPage(rendering_story.RenderingStory): class ToughSchedulingPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
TAGS = [story_tags.TOUGH_SCHEDULING]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -13,7 +13,7 @@ class ToughFastScrollingPage(rendering_story.RenderingStory): ...@@ -13,7 +13,7 @@ class ToughFastScrollingPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
SPEED_IN_PIXELS_PER_SECOND = None SPEED_IN_PIXELS_PER_SECOND = None
SYNTHETIC_GESTURE_SOURCE = page_action.GESTURE_SOURCE_DEFAULT SYNTHETIC_GESTURE_SOURCE = page_action.GESTURE_SOURCE_DEFAULT
TAGS = [story_tags.GPU_RASTERIZATION] TAGS = [story_tags.GPU_RASTERIZATION, story_tags.TOUGH_SCROLLING]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -5,10 +5,12 @@ from telemetry.page import shared_page_state ...@@ -5,10 +5,12 @@ from telemetry.page import shared_page_state
from telemetry import story from telemetry import story
from page_sets.rendering import rendering_story from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
class ToughTextureUploadPage(rendering_story.RenderingStory): class ToughTextureUploadPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
TAGS = [story_tags.TOUGH_TEXTURE_UPLOAD]
def __init__(self, def __init__(self,
page_set, page_set,
......
...@@ -11,7 +11,7 @@ from page_sets.rendering import story_tags ...@@ -11,7 +11,7 @@ from page_sets.rendering import story_tags
class ToughWebglPage(rendering_story.RenderingStory): class ToughWebglPage(rendering_story.RenderingStory):
ABSTRACT_STORY = True ABSTRACT_STORY = True
TAGS = [story_tags.REQUIRED_WEBGL] TAGS = [story_tags.REQUIRED_WEBGL, story_tags.TOUGH_WEBGL]
def __init__(self, def __init__(self,
page_set, page_set,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment