Commit 8940a78e authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Stop explicitly setting strip_absolute_paths_from_debug_symbols to true.

It's been defaulted to true for a while now on Linux and Windows,
so rely on the default setting instead.

Bug: none
Change-Id: Id24297dff08b28ee5e28f6cb6267018a4a1443e1
Reviewed-on: https://chromium-review.googlesource.com/c/1294298Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601777}
parent 900336ff
...@@ -41,7 +41,6 @@ is_official_build = true ...@@ -41,7 +41,6 @@ is_official_build = true
dcheck_always_on = true dcheck_always_on = true
is_component_build = false is_component_build = false
is_debug = false is_debug = false
strip_absolute_paths_from_debug_symbols = true
blink_symbol_level = 1 blink_symbol_level = 1
symbol_level = 1 symbol_level = 1
......
...@@ -275,11 +275,10 @@ your "gn args". ...@@ -275,11 +275,10 @@ your "gn args".
### Source level debug with -fdebug-compilation-dir ### Source level debug with -fdebug-compilation-dir
When you enable GN config `strip_absolute_paths_from_debug_symbols`, this is When `strip_absolute_paths_from_debug_symbols` is enabled (which is the
enabled by default for goma on Linux build, you need to add following command default) you need to add following command to your `~/.gdbinit` for source
to your `~/.gdbinit` for source level debugging to load customized level debugging to load customized [gdbinit](../tools/gdb/gdbinit) or copy the
[gdbinit](../tools/gdb/gdbinit) or copy the content of the file to your content of the file to your `~/.gdbinit`.
`~/.gdbinit`.
``` ```
source path/to/chromium/src/tools/gdb/gdbinit source path/to/chromium/src/tools/gdb/gdbinit
......
...@@ -1930,12 +1930,7 @@ ...@@ -1930,12 +1930,7 @@
}, },
'goma': { 'goma': {
# The MB code will properly escape goma_dir if necessary in the GYP 'gn_args': 'use_goma=true',
# code path; the GN code path needs no escaping.
# We also set strip_absolute_paths to ensure that we can get deterministic
# builds. This isn't just on by default when goma is on so that devs
# can do goma builds but still be able to debug by default.
'gn_args': 'use_goma=true strip_absolute_paths_from_debug_symbols=true',
}, },
'gpu_fyi_tests': { 'gpu_fyi_tests': {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment