Skip to content

GitLab

T
tangled
Commit 895678e6 authored by Eric Willigers's avatar Eric Willigers Committed by Commit Bot
Browse files
Options

CSS: WPT for perspective-origin parsing 

Test that perspective-origin supports the <position> grammar
https://drafts.csswg.org/css-transforms-2/#perspective-origin-property
https://drafts.csswg.org/css-values-4/#typedef-position

and not the additional forms allowed by the <bg-position> grammar
https://drafts.csswg.org/css-backgrounds-3/#propdef-background-position

Blink has deprecated <bg-position> support in perspective-origin
(and other contexts other than background-position), so the expected
failures are while we wait for removal in M68.

BUG=804187

Change-Id: I9e93af5a5af0975fca82aadd4485c601c439969f
Reviewed-on: https://chromium-review.googlesource.com/895222
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: default avatarnainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533258}
parent ac722cb0
Hide whitespace changes
Inline Side-by-side
Showing with 97 additions and 6 deletions
third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/perspective-origin-parsing-invalid-expected.txt 0 → 100644
View file @ 895678e6
This is a testharness.js-based test.
PASS e.style['perspective-origin'] = "auto" should not set the property value
PASS e.style['perspective-origin'] = "1px 2px 3px" should not set the property value
PASS e.style['perspective-origin'] = "left right" should not set the property value
PASS e.style['perspective-origin'] = "bottom 10% top 20%" should not set the property value
FAIL e.style['perspective-origin'] = "center left 1px" should not set the property value assert_equals: expected "" but got "left 1px center"
FAIL e.style['perspective-origin'] = "center top 2px" should not set the property value assert_equals: expected "" but got "center top 2px"
FAIL e.style['perspective-origin'] = "right 3% center" should not set the property value assert_equals: expected "" but got "right 3% center"
FAIL e.style['perspective-origin'] = "left 4px top" should not set the property value assert_equals: expected "" but got "left 4px top"
FAIL e.style['perspective-origin'] = "right top 5px" should not set the property value assert_equals: expected "" but got "right top 5px"
FAIL e.style['perspective-origin'] = "bottom 6% center" should not set the property value assert_equals: expected "" but got "center bottom 6%"
FAIL e.style['perspective-origin'] = "bottom 7% left" should not set the property value assert_equals: expected "" but got "left bottom 7%"
FAIL e.style['perspective-origin'] = "bottom right 8%" should not set the property value assert_equals: expected "" but got "right 8% bottom"
Harness: the test ran to completion.
third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/perspective-origin-parsing-invalid.html 0 → 100644
View file @ 895678e6
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>CSS Transform Module Level 2: parsing perspective-origin with invalid values</title>
<link rel="author" title="Eric Willigers" href="mailto:ericwilligers@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-transforms-2/#perspective-origin-property">
<meta name="assert" content="perspective-origin supports only the '<position>' grammar.">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/parsing-testcommon.js"></script>
</head>
<body>
<script>
test_invalid_value("perspective-origin", "auto");
test_invalid_value("perspective-origin", "1px 2px 3px");
test_invalid_value("perspective-origin", "left right");
test_invalid_value("perspective-origin", "bottom 10% top 20%");
// The following were supported in an earlier version of the spec.
// https://github.com/w3c/csswg-drafts/issues/2140
// Deprecated in Blink with support to be removed in M68, around July 2018.
test_invalid_value("perspective-origin", "center left 1px");
test_invalid_value("perspective-origin", "center top 2px");
test_invalid_value("perspective-origin", "right 3% center");
test_invalid_value("perspective-origin", "left 4px top");
test_invalid_value("perspective-origin", "right top 5px");
test_invalid_value("perspective-origin", "bottom 6% center");
test_invalid_value("perspective-origin", "bottom 7% left");
test_invalid_value("perspective-origin", "bottom right 8%");
</script>
</body>
</html>
third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/perspective-origin-parsing-valid.html 0 → 100644
View file @ 895678e6
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>CSS Transform Module Level 2: parsing perspective-origin with valid values</title>
<link rel="author" title="Eric Willigers" href="mailto:ericwilligers@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-transforms-2/#perspective-origin-property">
<meta name="assert" content="perspective-origin supports the full '<position>' grammar.">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/parsing-testcommon.js"></script>
</head>
<body>
<script>
// Blink and WebKit append center. Edge and Firefox append 50%
test_valid_value("perspective-origin", "10%", ["10% center", "10% 50%"]);
test_valid_value("perspective-origin", "20% 30px");
test_valid_value("perspective-origin", "30px center");
test_valid_value("perspective-origin", "40px top");
test_valid_value("perspective-origin", "bottom 10% right 20%", "right 20% bottom 10%");
test_valid_value("perspective-origin", "bottom right", "right bottom");
test_valid_value("perspective-origin", "center", ["center center", "center 50%"]);
test_valid_value("perspective-origin", "center 50px");
test_valid_value("perspective-origin", "center bottom");
test_valid_value("perspective-origin", "center center");
test_valid_value("perspective-origin", "center left", "left center");
test_valid_value("perspective-origin", "left", ["left center", "left 50%"]);
test_valid_value("perspective-origin", "left bottom");
test_valid_value("perspective-origin", "left center");
test_valid_value("perspective-origin", "right 40%");
test_valid_value("perspective-origin", "right 30% top 60px");
test_valid_value("perspective-origin", "top", ["center top", "50% top"]);
test_valid_value("perspective-origin", "top center", "center top");
</script>
</body>
</html>
third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/resources/parsing-testcommon.js
View file @ 895678e6
'use strict';
// serializedValue can be the expected serialization of value,
// or an array of permitted serializations,
// or omitted if value should serialize as value.
function test_valid_value(property, value, serializedValue) {
if (arguments.length < 3)
serializedValue = value;
......@@ -9,17 +12,20 @@ function test_valid_value(property, value, serializedValue) {
test(function(){
var div = document.createElement('div');
div.style[property] = value;
assert_not_equals(div.style[property], "");
}, "e.style['" + property + "'] = " + stringifiedValue + " should set the property value");
assert_not_equals(div.style[property], "", "property should be set");
test(function(){
var div = document.createElement('div');
div.style[property] = value;
var readValue = div.style[property];
assert_equals(readValue, serializedValue);
if (serializedValue instanceof Array)
assert_true(serializedValue.includes(readValue), "serialization should be sound");
else
assert_equals(readValue, serializedValue, "serialization should be canonical");
div.style[property] = readValue;
assert_equals(div.style[property], readValue);
}, "Serialization should round-trip after setting e.style['" + property + "'] = " + stringifiedValue);
assert_equals(div.style[property], readValue, "serialization should round-trip");
}, "e.style['" + property + "'] = " + stringifiedValue + " should set the property value");
}
function test_invalid_value(property, value) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment