Extensions: Always add base tag

Always add the <base href="chrome://extensions> tag, even in optimized builds, since it no longer needs to be added by the optimize_webui script. This is because Polymer 3 pages use rollup rather than Polymer bundler. Rollup does not process HTML files and therefore does not have the same issue with eating <base> tags that Polymer bundler did. The base tag is needed for URLs like chrome://extensions/a/b/ to work correctly and not cause a console error. Bug: 1004967 Change-Id: I9b8b6c20ebe8de1a6a5c92361079321b124fa6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918644Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#715568}

Extensions: Always add base tag
Always add the <base href="chrome://extensions> tag, even in optimized builds, since it no longer needs to be added by the optimize_webui script. This is because Polymer 3 pages use rollup rather than Polymer bundler. Rollup does not process HTML files and therefore does not have the same issue with eating <base> tags that Polymer bundler did. The base tag is needed for URLs like chrome://extensions/a/b/ to work correctly and not cause a console error. Bug: 1004967 Change-Id: I9b8b6c20ebe8de1a6a5c92361079321b124fa6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918644Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#715568}
896db8dc · rbpotter · Commit Bot · 6c9a2e5f · 896db8dc · 896db8dc
Commit 896db8dc authored Nov 15, 2019 by rbpotter Committed by Commit Bot Nov 15, 2019
3 changed files
--- a/chrome/browser/resources/extensions/extensions.html
+++ b/chrome/browser/resources/extensions/extensions.html
@@ -4,9 +4,7 @@
 <head>
  <meta charset="utf8">
  <title>$i18n{title}</title>
-<if expr="not optimize_webui">
  <base href="chrome://extensions">
-</if>
  <link rel="stylesheet" href="chrome://resources/css/md_colors.css">
  <style>
    html {

--- a/chrome/browser/resources/extensions/extensions_resources.grd
+++ b/chrome/browser/resources/extensions/extensions_resources.grd
@@ -113,8 +113,6 @@
                 type="chrome_html" />
      <structure name="IDR_EXTENSIONS_EXTENSIONS_HTML"
                 file="extensions.html"
-                 flattenhtml="true"
-                 allowexternalscript="true"
                 type="chrome_html" />
      <structure name="IDR_EXTENSIONS_DRAG_AND_DROP_HANDLER_JS"
                 file="drag_and_drop_handler.js"

--- a/chrome/browser/resources/extensions/extensions_resources_vulcanized.grd
+++ b/chrome/browser/resources/extensions/extensions_resources_vulcanized.grd
@@ -15,8 +15,6 @@
      <include name="IDR_EXTENSIONS_VULCANIZED_HTML"
               file="${root_gen_dir}\chrome\browser\resources\extensions\vulcanized.html"
               use_base_dir="false"
-               flattenhtml="true"
-               allowexternalscript="true"
               type="BINDATA"
               compress="gzip" />
      <include name="IDR_EXTENSIONS_CRISPER_JS"