Files app: Added some error logs

Combed log and error messages related to mounting and unmounting of file
systems.

Change-Id: I07acbdb4ccbc22aa913cb776c1d515c01a226422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732672Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683892}

ui/file_manager/file_manager/background/js/volume_manager_impl.js

@@ -174,6 +174,8 @@ class VolumeManagerImpl extends cr.EventTarget {
             const volumeInfo =
                 await this.addVolumeMetadata_(event.volumeMetadata);
             this.finishRequest_(requestKey, event.status, volumeInfo);
+            console.warn(`Mounted '${event.volumeMetadata.sourcePath}' as '${
+                event.volumeMetadata.volumeId}'`);
             break;
           }
 
@@ -184,6 +186,9 @@ class VolumeManagerImpl extends cr.EventTarget {
             navigationEvent.volumeId = event.volumeMetadata.volumeId;
             this.dispatchEvent(navigationEvent);
             this.finishRequest_(requestKey, event.status);
+            console.error(`'Cannot mount ${
+                event.volumeMetadata.sourcePath}': Already mounted as '${
+                event.volumeMetadata.volumeId}'`);
             break;
           }
 
@@ -211,6 +216,9 @@ class VolumeManagerImpl extends cr.EventTarget {
           this.finishRequest_(requestKey, status);
           if (event.status === 'success') {
             this.volumeInfoList.remove(event.volumeMetadata.volumeId);
+            console.warn(`Unmounted '${volumeId}'`);
+          } else {
+            console.error(`Cannot unmount '${volumeId}': ${event.status}`);
           }
 
           break;
@@ -240,9 +248,7 @@ class VolumeManagerImpl extends cr.EventTarget {
     });
     console.warn(`Mounting '${path}'`);
     const key = this.makeRequestKey_('mount', path);
-    const volumeInfo = await this.startRequest_(key);
-    console.warn(`Mounted '${path}' as '${volumeInfo.volumeId}'`);
-    return volumeInfo;
+    return this.startRequest_(key);
   }
 
   /** @override */
@@ -251,7 +257,6 @@ class VolumeManagerImpl extends cr.EventTarget {
     chrome.fileManagerPrivate.removeMount(volumeInfo.volumeId);
     const key = this.makeRequestKey_('unmount', volumeInfo.volumeId);
     await this.startRequest_(key);
-    console.warn(`Unmounted '${volumeInfo.volumeId}'`);
   }
 
   /** @override */

ui/file_manager/file_manager/foreground/js/file_manager_commands.js

@@ -592,7 +592,7 @@ CommandHandler.COMMANDS_['unmount'] = new class extends Command {
         await fileManager.volumeManager.unmount(volume);
       } catch (error) {
         console.error(
-            `Cannot unmount ${volume.volumeId}: ${error.stack || error}`);
+            `Cannot unmount '${volume.volumeId}': ${error.stack || error}`);
         errorCallback(volume.volumeType);
       }
     });

ui/file_manager/file_manager/foreground/js/file_tasks.js

@@ -922,6 +922,7 @@ class FileTasks {
           this.ui_.alertDialog.show(
               strf('ARCHIVE_MOUNT_FAILED', path.substr(namePos + 1), error),
               null, null);
+          console.error(`Cannot mount '${path}': ${error.stack || error}`);
         }
       });