Commit 89a6b640 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Enable "gn check" for //third_party/blink/renderer/modules/webcodecs

webcodecs:unit_tests had a circular dependency with
controller:blink_unittests_sources. This CL moves out
controller:blink_bindings_test_sources from
controller:blink_unittests_sources and adds
controller:blink_bindings_test_sources dependency to
webcodecs:unit_tests to remove the circular dependency.

This CL has no behavior changes.

Bug: 800764
Change-Id: Ie578dfe442f2ee111f19abb7496e41a27ff66b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400644
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Reviewed-by: default avatarThomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805558}
parent 405ed4ac
......@@ -256,7 +256,6 @@ no_check_targets = [
"//third_party/blink/renderer/modules/manifest:*", # 2 errors
"//third_party/blink/renderer/modules/media_capabilities:*", # 5 errors
"//third_party/blink/renderer/modules/peerconnection:*", # 43 errors
"//third_party/blink/renderer/modules/webcodecs:*", # 13 errors
"//third_party/blink/renderer/modules/webtransport:*", # 16 errors
"//third_party/blink/renderer/modules:*", # 321 errors
"//third_party/blink/renderer/platform/heap:*", # 65 errors
......
......@@ -167,6 +167,27 @@ source_set("blink_perf_tests_sources") {
]
}
source_set("blink_bindings_test_sources") {
testonly = true
sources = bindings_unittest_files
deps = [
"//base/test:test_support",
"//testing/gmock",
"//testing/gtest",
"//third_party/blink/public:test_headers",
"//third_party/blink/renderer/core:testing",
"//third_party/blink/renderer/core:unit_tests",
"//third_party/blink/renderer/modules:modules",
"//third_party/blink/renderer/platform:platform",
"//third_party/blink/renderer/platform:test_support",
]
configs += [
"//third_party/blink/renderer:config",
"//third_party/blink/renderer:inside_blink",
"//third_party/blink/renderer/core:blink_core_pch",
]
}
source_set("blink_unittests_sources") {
visibility = [] # Allow re-assignment of list.
visibility = [ "*" ]
......@@ -177,7 +198,6 @@ source_set("blink_unittests_sources") {
"performance_manager/v8_worker_memory_reporter_test.cc",
"tests/run_all_tests.cc",
]
sources += bindings_unittest_files
if (is_linux || is_chromeos) {
sources += [ "memory_usage_monitor_posix_test.cc" ]
}
......@@ -197,6 +217,7 @@ source_set("blink_unittests_sources") {
}
deps = [
":blink_bindings_test_sources",
":controller",
"//base",
"//base:i18n",
......
......@@ -53,6 +53,11 @@ blink_modules_sources("webcodecs") {
"//media/mojo:buildflags",
"//media/mojo/clients",
"//media/mojo/mojom",
"//third_party/libyuv:libyuv",
]
public_deps = [
"//third_party/blink/renderer/modules/mediastream:mediastream",
"//third_party/blink/renderer/modules/webaudio:webaudio",
]
}
......@@ -78,10 +83,14 @@ source_set("unit_tests") {
"//base/test:test_support",
"//gpu/command_buffer/common",
"//media:test_support",
"//media/mojo/services:services",
"//testing/gmock",
"//testing/gtest",
"//third_party/blink/public:test_headers",
"//third_party/blink/renderer/controller:blink_bindings_test_sources",
"//third_party/blink/renderer/modules",
"//third_party/blink/renderer/platform",
"//third_party/blink/renderer/platform:test_support",
"//third_party/blink/renderer/platform/wtf",
"//third_party/libyuv",
]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment