Commit 89ae4104 authored by Abigail Klein's avatar Abigail Klein Committed by Chromium LUCI CQ

[Live Caption] Set an accessible window name for the caption bubble.

Bug: 1055150, 1161040
Change-Id: I128a2fccdc671a5aab0ad15c3a9e5089ae797168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605352Reviewed-by: default avatarJosiah Krutz <josiahk@google.com>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#839797}
parent 7ddd54a6
......@@ -594,6 +594,10 @@ void CaptionBubble::GetAccessibleNodeData(ui::AXNodeData* node_data) {
node_data->SetName(title_->GetText());
}
base::string16 CaptionBubble::GetAccessibleWindowTitle() const {
return title_->GetText();
}
void CaptionBubble::AddedToWidget() {
DCHECK(GetWidget());
DCHECK(GetAnchorView());
......
......@@ -98,6 +98,7 @@ class CaptionBubble : public views::BubbleDialogDelegateView {
void OnFocus() override;
void OnBlur() override;
void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
base::string16 GetAccessibleWindowTitle() const override;
void AddedToWidget() override;
private:
......
......@@ -68,6 +68,13 @@ class CaptionBubbleControllerViewsTest : public InProcessBrowserTest {
return controller_ ? controller_->caption_bubble_->title_ : nullptr;
}
std::string GetAccessibleWindowTitle() {
return controller_
? base::UTF16ToUTF8(
controller_->caption_bubble_->GetAccessibleWindowTitle())
: "";
}
views::Button* GetCloseButton() {
return controller_ ? controller_->caption_bubble_->close_button_ : nullptr;
}
......@@ -1091,4 +1098,12 @@ IN_PROC_BROWSER_TEST_F(CaptionBubbleControllerViewsTest, HidesAfterInactivity) {
EXPECT_FALSE(IsWidgetVisible());
}
IN_PROC_BROWSER_TEST_F(CaptionBubbleControllerViewsTest,
HasAccessibleWindowTitle) {
OnPartialTranscription("A turtle's shell is part of its skeleton.");
EXPECT_FALSE(GetAccessibleWindowTitle().empty());
EXPECT_EQ(GetAccessibleWindowTitle(),
base::UTF16ToUTF8(GetTitle()->GetText()));
}
} // namespace captions
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment