Commit 89e1edce authored by Eric Robinson's avatar Eric Robinson Committed by Commit Bot

Turn off redirect feature.

We are turning off this feature until our framework for detecting if a site is
commonly visited also includes redirects as well.  Worry if a common redirecter
makes it on to our black list, then we would end up blocking all navigations
through that redirecter.

Bug: 859904
Change-Id: I02bb128a422cfce354d83326efc677eb9a8c7462
Reviewed-on: https://chromium-review.googlesource.com/1142038Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576515}
parent 1f46b374
......@@ -404,6 +404,11 @@ TEST_F(SafeBrowsingTriggeredPopupBlockerTest, WarningMatch_OnlyLogs) {
}
TEST_F(SafeBrowsingTriggeredPopupBlockerTest, ActivationPosition) {
// Turn on the feature to perform safebrowsing on redirects.
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndEnableFeature(
subresource_filter::kSafeBrowsingSubresourceFilterConsiderRedirects);
const GURL enforce_url("https://enforce.test/");
const GURL warn_url("https://warn.test/");
MarkUrlAsAbusiveEnforce(enforce_url);
......
......@@ -232,7 +232,7 @@ const base::Feature kSafeBrowsingSubresourceFilter{
"SubresourceFilter", base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kSafeBrowsingSubresourceFilterConsiderRedirects{
"SubresourceFilterConsiderRedirects", base::FEATURE_ENABLED_BY_DEFAULT};
"SubresourceFilterConsiderRedirects", base::FEATURE_DISABLED_BY_DEFAULT};
// Legacy name `activation_state` is used in variation parameters.
const char kActivationLevelParameterName[] = "activation_state";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment