chromecast: Migrate IS_CHROMECAST to common buildflag

The IS_CHROMECAST define is declared in 16 different places, which is
risky especially if the define is used in a header file.

Move this to a common buildflag header in //build, alongside the chrome
branding flags. This flag needs to be in a widely scoped location, since
we don't know if we're allowed to use //chromecast until we check the
flag's value.

OS_CHROMEOS uses a global #define for this, and that would work here, but
global ifdefs are discouraged. There are few enough uses of IS_CHROMECAST
that having explicit dependencies on a buildflag header isn't too onerous.

No functional change.

Bug: 1030969
TBR=kylechar@chromium.org, dgozman@chromium.org, benwells@chromium.org, kbr@chromium.org, dalecurtis@chromium.org, reillyg@chromium.org, foolip@chromium.org

Change-Id: I48d9ffccde7e7a680ce572f15a8ba1ef11adcc6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951981
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722665}

base/BUILD.gn

@@ -2243,6 +2243,7 @@ component("i18n") {
   deps = [
     ":base",
     "//base/third_party/dynamic_annotations",
+    "//build:chromecast_buildflags",
   ]
 
   if (!is_debug) {

base/i18n/icu_util.cc

@@ -18,6 +18,7 @@
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "third_party/icu/source/common/unicode/putil.h"
 #include "third_party/icu/source/common/unicode/udata.h"
 
@@ -43,7 +44,7 @@
 #endif
 
 #if defined(OS_ANDROID) || defined(OS_FUCHSIA) || \
-    (defined(OS_LINUX) && !defined(IS_CHROMECAST))
+    (defined(OS_LINUX) && !BUILDFLAG(IS_CHROMECAST))
 #include "third_party/icu/source/i18n/unicode/timezone.h"
 #endif
 
@@ -288,7 +289,7 @@ void InitializeIcuTimeZone() {
       fuchsia::IntlProfileWatcher::GetPrimaryTimeZoneIdForIcuInitialization();
   icu::TimeZone::adoptDefault(
       icu::TimeZone::createTimeZone(icu::UnicodeString::fromUTF8(zone_id)));
-#elif defined(OS_LINUX) && !defined(IS_CHROMECAST)
+#elif defined(OS_LINUX) && !BUILDFLAG(IS_CHROMECAST)
   // To respond to the timezone change properly, the default timezone
   // cache in ICU has to be populated on starting up.
   // See TimeZoneMonitorLinux::NotifyClientsFromImpl().

build/BUILD.gn

@@ -4,6 +4,7 @@
 
 import("//build/buildflag_header.gni")
 import("//build/config/chrome_build.gni")
+import("//build/config/chromecast_build.gni")
 
 source_set("buildflag_header_h") {
   sources = [
@@ -26,3 +27,9 @@ buildflag_header("branding_buildflags") {
     ]
   }
 }
+
+buildflag_header("chromecast_buildflags") {
+  header = "chromecast_buildflags.h"
+
+  flags = [ "IS_CHROMECAST=$is_chromecast" ]
+}

chromecast/gpu/BUILD.gn

@@ -18,6 +18,4 @@ cast_source_set("gpu") {
     "//content/public/child",
     "//content/public/gpu",
   ]
-
-  defines = [ "IS_CHROMECAST" ]
 }

components/viz/service/BUILD.gn

@@ -190,6 +190,7 @@ viz_component("service") {
   allow_circular_includes_from = [ ":gpu_service_dependencies" ]
 
   deps = [
+    "//build:chromecast_buildflags",
     "//cc/base",
     "//cc/paint",
     "//components/crash/core/common:crash_key",
@@ -241,7 +242,6 @@ viz_component("service") {
   }
 
   if (is_chromecast) {
-    defines += [ "IS_CHROMECAST" ]
     deps += [ "//chromecast/media/service/mojom" ]
   }
 

components/viz/service/display/overlay_strategy_underlay_cast.cc

@@ -7,13 +7,14 @@
 #include "base/containers/adapters.h"
 #include "base/lazy_instance.h"
 #include "base/unguessable_token.h"
+#include "build/chromecast_buildflags.h"
 #include "components/viz/common/quads/draw_quad.h"
 #include "components/viz/common/quads/solid_color_draw_quad.h"
 #include "components/viz/common/quads/video_hole_draw_quad.h"
 #include "components/viz/service/display/overlay_candidate_list.h"
 #include "ui/gfx/geometry/rect_conversions.h"
 
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
 #include "base/no_destructor.h"
 #include "mojo/public/cpp/bindings/remote.h"
 #endif
@@ -24,7 +25,7 @@ namespace {
 base::LazyInstance<OverlayStrategyUnderlayCast::OverlayCompositedCallback>::
     DestructorAtExit g_overlay_composited_callback = LAZY_INSTANCE_INITIALIZER;
 
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
 // This persistent mojo::Remote is bound then used by all the instances
 // of OverlayStrategyUnderlayCast.
 mojo::Remote<chromecast::media::mojom::VideoGeometrySetter>&
@@ -113,7 +114,7 @@ bool OverlayStrategyUnderlayCast::Attempt(
 
       // TODO(guohuideng): when migration to GPU process complete, remove
       // the code that's for the browser process compositor.
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
       if (g_overlay_composited_callback.Get().is_null()) {
         DCHECK(GetVideoGeometrySetter());
         GetVideoGeometrySetter()->SetVideoGeometry(
@@ -149,7 +150,7 @@ void OverlayStrategyUnderlayCast::SetOverlayCompositedCallback(
   g_overlay_composited_callback.Get() = cb;
 }
 
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
 // static
 void OverlayStrategyUnderlayCast::ConnectVideoGeometrySetter(
     mojo::PendingRemote<chromecast::media::mojom::VideoGeometrySetter>

components/viz/service/display/overlay_strategy_underlay_cast.h

@@ -9,11 +9,12 @@
 
 #include "base/callback.h"
 #include "base/macros.h"
+#include "build/chromecast_buildflags.h"
 #include "components/viz/service/display/overlay_strategy_underlay.h"
 #include "components/viz/service/viz_service_export.h"
 #include "ui/gfx/overlay_transform.h"
 
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
 #include "chromecast/media/service/mojom/video_geometry_setter.mojom.h"
 #include "mojo/public/cpp/bindings/pending_remote.h"
 #endif
@@ -46,7 +47,7 @@ class VIZ_SERVICE_EXPORT OverlayStrategyUnderlayCast
       base::RepeatingCallback<void(const gfx::RectF&, gfx::OverlayTransform)>;
   static void SetOverlayCompositedCallback(const OverlayCompositedCallback& cb);
 
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
   // In Chromecast build, OverlayStrategyUnderlayCast needs a valid mojo
   // interface to VideoGeometrySetter Service (shared by all instances of
   // OverlaystrategyUnderlayCast). This must be called before compositor starts.

components/viz/service/display_embedder/output_surface_provider_impl.cc

@@ -11,6 +11,7 @@
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "build/chromecast_buildflags.h"
 #include "cc/base/switches.h"
 #include "components/viz/common/display/renderer_settings.h"
 #include "components/viz/common/frame_sinks/begin_frame_source.h"
@@ -127,7 +128,7 @@ std::unique_ptr<OutputSurface> OutputSurfaceProviderImpl::CreateOutputSurface(
           renderer_settings);
     }
     if (!output_surface) {
-#if defined(OS_CHROMEOS) || defined(IS_CHROMECAST)
+#if defined(OS_CHROMEOS) || BUILDFLAG(IS_CHROMECAST)
       // GPU compositing is expected to always work on Chrome OS so we should
       // never encounter fatal context error. This could be an unrecoverable
       // hardware error or a bug.
@@ -165,7 +166,7 @@ std::unique_ptr<OutputSurface> OutputSurfaceProviderImpl::CreateOutputSurface(
 #endif
 
       if (IsFatalOrSurfaceFailure(context_result)) {
-#if defined(OS_CHROMEOS) || defined(IS_CHROMECAST)
+#if defined(OS_CHROMEOS) || BUILDFLAG(IS_CHROMECAST)
         // GL compositing is expected to always work on Chrome OS so we should
         // never encounter fatal context error. This could be an unrecoverable
         // hardware error or a bug.

components/viz/service/main/BUILD.gn

@@ -51,7 +51,6 @@ source_set("main") {
   }
 
   if (is_chromecast) {
-    defines += [ "IS_CHROMECAST" ]
     deps += [ "//chromecast/media/service/mojom" ]
   }
 }

content/browser/BUILD.gn

@@ -1983,10 +1983,6 @@ jumbo_source_set("browser") {
     defines += [ "ENABLE_PROTECTED_MEDIA_IDENTIFIER_PERMISSION" ]
   }
 
-  if (is_chromecast) {
-    defines += [ "IS_CHROMECAST" ]
-  }
-
   if (is_chromecast && is_linux) {
     sources += [
       "tracing/cast_tracing_agent.cc",

content/browser/message_port_provider.cc

@@ -7,6 +7,7 @@
 #include <utility>
 
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
@@ -79,7 +80,7 @@ void MessagePortProvider::PostMessageToFrame(
 }
 #endif
 
-#if defined(OS_FUCHSIA) || defined(IS_CHROMECAST)
+#if defined(OS_FUCHSIA) || BUILDFLAG(IS_CHROMECAST)
 // static
 void MessagePortProvider::PostMessageToFrame(
     WebContents* web_contents,

content/browser/tracing/tracing_controller_browsertest.cc

@@ -17,6 +17,7 @@
 #include "base/threading/thread_restrictions.h"
 #include "base/values.h"
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "content/browser/tracing/tracing_controller_impl.h"
 #include "content/public/browser/browser_task_traits.h"
 #include "content/public/browser/browser_thread.h"
@@ -461,7 +462,7 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest, DoubleStopTracing) {
 }
 
 // Only CrOS and Cast support system tracing.
-#if defined(OS_CHROMEOS) || (defined(IS_CHROMECAST) && defined(OS_LINUX))
+#if defined(OS_CHROMEOS) || (BUILDFLAG(IS_CHROMECAST) && defined(OS_LINUX))
 #define MAYBE_SystemTraceEvents SystemTraceEvents
 #else
 #define MAYBE_SystemTraceEvents DISABLED_SystemTraceEvents

content/public/browser/BUILD.gn

@@ -412,6 +412,7 @@ jumbo_source_set("browser_sources") {
   }
 
   public_deps = [
+    "//build:chromecast_buildflags",
     "//components/download/public/common:public",
     "//content/public/common:common_sources",
     "//ipc",

content/public/browser/message_port_provider.h

@@ -12,13 +12,14 @@
 #include "base/optional.h"
 #include "base/strings/string16.h"
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "content/common/content_export.h"
 
 #if defined(OS_ANDROID)
 #include "base/android/scoped_java_ref.h"
 #endif
 
-#if defined(OS_FUCHSIA) || defined(IS_CHROMECAST)
+#if defined(OS_FUCHSIA) || BUILDFLAG(IS_CHROMECAST)
 #include "third_party/blink/public/common/messaging/message_port_channel.h"
 #endif
 
@@ -49,7 +50,7 @@ class CONTENT_EXPORT MessagePortProvider {
       const base::android::JavaParamRef<jobjectArray>& ports);
 #endif  // OS_ANDROID
 
-#if defined(OS_FUCHSIA) || defined(IS_CHROMECAST)
+#if defined(OS_FUCHSIA) || BUILDFLAG(IS_CHROMECAST)
   // If |target_origin| is unset, then no origin scoping is applied.
   static void PostMessageToFrame(
       WebContents* web_contents,
@@ -57,7 +58,7 @@ class CONTENT_EXPORT MessagePortProvider {
       const base::Optional<base::string16>& target_origin,
       const base::string16& data,
       std::vector<mojo::ScopedMessagePipeHandle> channels);
-#endif  // OS_FUCHSIA || IS_CHROMECAST
+#endif  // OS_FUCHSIA || BUILDFLAG(IS_CHROMECAST)
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(MessagePortProvider);

content/renderer/BUILD.gn

@@ -664,10 +664,6 @@ target(link_target_type, "renderer") {
   if (enable_ipc_fuzzer) {
     configs += [ "//tools/ipc_fuzzer:ipc_fuzzer_config" ]
   }
-
-  if (is_chromecast) {
-    defines += [ "IS_CHROMECAST" ]
-  }
 }
 
 # See comment at the top of //content/BUILD.gn for how this works.

content/test/BUILD.gn

@@ -1064,10 +1064,6 @@ test("content_browsertests") {
 
   defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
 
-  if (is_chromecast) {
-    defines += [ "IS_CHROMECAST" ]
-  }
-
   configs += [
     "//build/config:precompiled_headers",
     "//build/config/compiler:no_size_t_to_int_warning",
@@ -1080,6 +1076,7 @@ test("content_browsertests") {
     ":web_test_support",
     ":web_ui_test_mojo_bindings",
     "//base/test:test_support",
+    "//build:chromecast_buildflags",
     "//components/discardable_memory/client",
     "//components/discardable_memory/common",
     "//components/discardable_memory/service",
@@ -1929,6 +1926,7 @@ test("content_unittests") {
     "//base/allocator:buildflags",
     "//base/test:test_support",
     "//base/third_party/dynamic_annotations",
+    "//build:chromecast_buildflags",
     "//cc",
     "//cc:test_support",
     "//components/cbor",
@@ -2089,10 +2087,6 @@ test("content_unittests") {
     ]
   }
 
-  if (is_chromecast) {
-    defines += [ "IS_CHROMECAST" ]
-  }
-
   # Screen capture unit tests.
   if (enable_screen_capture && !is_android) {
     deps += [

extensions/common/BUILD.gn

@@ -12,10 +12,6 @@ import("//testing/libfuzzer/fuzzer_test.gni")
 # TODO(crbug.com/731689): Assert that extensions are enabled.
 
 source_set("common_constants") {
-  if (is_chromecast) {
-    defines = [ "IS_CHROMECAST" ]
-  }
-
   sources = [
     "constants.cc",
     "constants.h",
@@ -23,6 +19,7 @@ source_set("common_constants") {
 
   deps = [
     "//base",
+    "//build:chromecast_buildflags",
     "//components/services/app_service/public/mojom",
     "//components/version_info:channel",
     "//ui/base",

extensions/common/constants.cc

@@ -6,6 +6,7 @@
 
 #include "base/stl_util.h"
 #include "base/strings/string_piece.h"
+#include "build/chromecast_buildflags.h"
 
 namespace extensions {
 
@@ -97,7 +98,7 @@ const char kMimeTypePng[] = "image/png";
 
 namespace extension_misc {
 
-#if defined(OS_CHROMEOS) || defined(IS_CHROMECAST)
+#if defined(OS_CHROMEOS) || BUILDFLAG(IS_CHROMECAST)
 // The extension id for the built-in component extension.
 const char kChromeVoxExtensionId[] = "mndnfokpggljbaajbnioimlmbfngpief";
 #else

gpu/ipc/service/BUILD.gn

@@ -53,14 +53,12 @@ jumbo_component("service") {
     "webgpu_command_buffer_stub.h",
   ]
   defines = [ "GPU_IPC_SERVICE_IMPLEMENTATION" ]
-  if (is_chromecast) {
-    defines += [ "IS_CHROMECAST" ]
-  }
   if (subpixel_font_rendering_disabled) {
     defines += [ "SUBPIXEL_FONT_RENDERING_DISABLED" ]
   }
   public_deps = [
     "//base",
+    "//build:chromecast_buildflags",
     "//components/viz/common",
     "//gpu/config",
     "//ipc",

gpu/ipc/service/gpu_init.cc

@@ -12,6 +12,7 @@
 #include "base/threading/scoped_blocking_call.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "components/viz/common/features.h"
 #include "gpu/command_buffer/service/gpu_switches.h"
 #include "gpu/command_buffer/service/service_utils.h"
@@ -109,7 +110,7 @@ void InitializePlatformOverlaySettings(GPUInfo* gpu_info) {
 #endif
 }
 
-#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && !defined(IS_CHROMECAST)
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && !BUILDFLAG(IS_CHROMECAST)
 bool CanAccessNvidiaDeviceFile() {
   bool res = true;
   base::ScopedBlockingCall scoped_blocking_call(FROM_HERE,
@@ -120,7 +121,7 @@ bool CanAccessNvidiaDeviceFile() {
   }
   return res;
 }
-#endif  // OS_LINUX && !OS_CHROMEOS && !IS_CHROMECAST
+#endif  // OS_LINUX && !OS_CHROMEOS && !BUILDFLAG(IS_CHROMECAST)
 
 class GpuWatchdogInit {
  public:
@@ -150,7 +151,7 @@ bool GpuInit::InitializeAndStartSandbox(base::CommandLine* command_line,
   // need more context based GPUInfo. In such situations, switching to
   // SwiftShader needs to wait until creating a context.
   bool needs_more_info = true;
-#if !defined(OS_ANDROID) && !defined(IS_CHROMECAST)
+#if !defined(OS_ANDROID) && !BUILDFLAG(IS_CHROMECAST)
   needs_more_info = false;
   if (!PopGPUInfoCache(&gpu_info_)) {
     CollectBasicGraphicsInfo(command_line, &gpu_info_);
@@ -181,7 +182,7 @@ bool GpuInit::InitializeAndStartSandbox(base::CommandLine* command_line,
     gpu_feature_info_ = gpu::ComputeGpuFeatureInfo(
         gpu_info_, gpu_preferences_, command_line, &needs_more_info);
   }
-#endif  // !OS_ANDROID && !IS_CHROMECAST
+#endif  // !OS_ANDROID && !BUILDFLAG(IS_CHROMECAST)
   gpu_info_.in_process_gpu = false;
   bool use_swiftshader = false;
 
@@ -545,7 +546,7 @@ void GpuInit::InitializeInProcess(base::CommandLine* command_line,
           ->GetSupportedFormatsForTexturing();
 #endif
   bool needs_more_info = true;
-#if !defined(IS_CHROMECAST)
+#if !BUILDFLAG(IS_CHROMECAST)
   needs_more_info = false;
   if (!PopGPUInfoCache(&gpu_info_)) {
     CollectBasicGraphicsInfo(command_line, &gpu_info_);
@@ -563,7 +564,7 @@ void GpuInit::InitializeInProcess(base::CommandLine* command_line,
     InitializeSwitchableGPUs(
         gpu_feature_info_.enabled_gpu_driver_bug_workarounds);
   }
-#endif  // !IS_CHROMECAST
+#endif  // !BUILDFLAG(IS_CHROMECAST)
 
   bool use_swiftshader = EnableSwiftShaderIfNeeded(
       command_line, gpu_feature_info_,

media/audio/BUILD.gn

@@ -32,9 +32,6 @@ if (is_android) {
 
 config("platform_config") {
   defines = []
-  if (is_chromecast) {
-    defines += [ "IS_CHROMECAST" ]
-  }
   if (use_alsa) {
     defines += [ "USE_ALSA" ]
   }
@@ -149,6 +146,7 @@ source_set("audio") {
   ]
   deps = [
     "//base",
+    "//build:chromecast_buildflags",
     "//media/base",
     "//url",
   ]

media/audio/audio_device_description.cc

@@ -8,6 +8,7 @@
 
 #include "base/bind.h"
 #include "base/logging.h"
+#include "build/chromecast_buildflags.h"
 #include "media/base/localized_strings.h"
 
 namespace media {
@@ -56,7 +57,7 @@ std::string AudioDeviceDescription::GetDefaultDeviceName() {
 std::string AudioDeviceDescription::GetCommunicationsDeviceName() {
 #if defined(OS_WIN)
   return GetLocalizedStringUTF8(COMMUNICATIONS_AUDIO_DEVICE_NAME);
-#elif defined(IS_CHROMECAST)
+#elif BUILDFLAG(IS_CHROMECAST)
   return "";
 #else
   NOTREACHED();

media/formats/BUILD.gn

@@ -74,6 +74,7 @@ source_set("formats") {
   ]
 
   deps = [
+    "//build:chromecast_buildflags",
     "//media:media_buildflags",
     "//media/base",
     "//third_party/libwebm",

media/formats/mp4/track_run_iterator.cc

@@ -13,6 +13,7 @@
 #include "base/numerics/checked_math.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/stl_util.h"
+#include "build/chromecast_buildflags.h"
 #include "media/base/decrypt_config.h"
 #include "media/base/demuxer_memory_limit.h"
 #include "media/base/encryption_pattern.h"
@@ -497,7 +498,7 @@ bool TrackRunIterator::Init(const MovieFragment& moof) {
           // If we don't have a per-sample IV, get the constant IV.
           bool is_encrypted = index == 0 ? track_encryption->is_encrypted
                                          : info_entry->is_encrypted;
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
           // On Chromecast, we only support setting the pattern values in the
           // 'tenc' box for the track (not varying on per sample group basis).
           // Thus we need to verify that the settings in the sample group
@@ -516,7 +517,7 @@ bool TrackRunIterator::Init(const MovieFragment& moof) {
                                 "sample group does not match that in the tenc "
                                 "box . This is not currently supported.");
           }
-#endif  // defined(IS_CHROMECAST)
+#endif  // BUILDFLAG(IS_CHROMECAST)
           if (is_encrypted && !iv_size) {
             const uint8_t constant_iv_size =
                 index == 0 ? track_encryption->default_constant_iv_size

media/mojo/services/BUILD.gn

@@ -171,13 +171,13 @@ source_set("media_manifest") {
   ]
   deps = [
     "//base",
+    "//build:chromecast_buildflags",
     "//media/mojo:buildflags",
     "//media/mojo/mojom",
     "//media/mojo/mojom:constants",
     "//services/service_manager/public/cpp",
   ]
   if (is_chromecast) {
-    defines = [ "IS_CHROMECAST" ]
     deps += [ "//chromecast/common/mojom" ]
   }
 }

media/mojo/services/media_manifest.cc

@@ -5,12 +5,13 @@
 #include "media/mojo/services/media_manifest.h"
 
 #include "base/no_destructor.h"
+#include "build/chromecast_buildflags.h"
 #include "media/mojo/buildflags.h"
 #include "media/mojo/mojom/constants.mojom.h"
 #include "media/mojo/mojom/media_service.mojom.h"
 #include "services/service_manager/public/cpp/manifest_builder.h"
 
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
 #include "chromecast/common/mojom/constants.mojom.h"
 #endif
 
@@ -36,7 +37,7 @@ const service_manager::Manifest& GetMediaManifest() {
         .ExposeCapability(
             "media:media",
             service_manager::Manifest::InterfaceList<mojom::MediaService>())
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
         .RequireCapability(chromecast::mojom::kChromecastServiceName,
                            "multizone")
 #endif
@@ -58,7 +59,7 @@ const service_manager::Manifest& GetMediaRendererManifest() {
         .ExposeCapability(
             "media:media",
             service_manager::Manifest::InterfaceList<mojom::MediaService>())
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
         .RequireCapability(chromecast::mojom::kChromecastServiceName,
                            "multizone")
 #endif

services/audio/BUILD.gn

@@ -66,6 +66,7 @@ source_set("audio") {
 
   deps = [
     ":testing_api_support",
+    "//build:chromecast_buildflags",
     "//components/crash/core/common:crash_key",  # Temporary: crbug.com/888478
   ]
 
@@ -101,10 +102,6 @@ source_set("audio") {
     "//media:media_config",
     "//media/audio:platform_config",
   ]
-
-  if (is_chromecast) {
-    defines = [ "IS_CHROMECAST" ]
-  }
 }
 
 # NOTE: This is its own component target because it exposes static storage

services/audio/stream_factory.cc

@@ -10,6 +10,7 @@
 #include "base/strings/stringprintf.h"
 #include "base/trace_event/trace_event.h"
 #include "base/unguessable_token.h"
+#include "build/chromecast_buildflags.h"
 #include "components/crash/core/common/crash_key.h"
 #include "media/audio/audio_device_description.h"
 #include "services/audio/input_stream.h"
@@ -126,7 +127,7 @@ void StreamFactory::CreateOutputStream(
   // This is required for multizone audio playback on Cast devices.
   // See //chromecast/media/cast_audio_manager.h for more information.
   const std::string device_id_or_group_id =
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
       (::media::AudioDeviceDescription::IsCommunicationsDevice(
            output_device_id) ||
        group_id.is_empty())

services/device/time_zone_monitor/BUILD.gn

@@ -24,6 +24,7 @@ source_set("time_zone_monitor") {
 
   deps = [
     "//base",
+    "//build:chromecast_buildflags",
     "//mojo/public/cpp/bindings",
     "//third_party/icu",
   ]
@@ -51,10 +52,6 @@ source_set("time_zone_monitor") {
   if (is_fuchsia) {
     sources += [ "time_zone_monitor_fuchsia.cc" ]
   }
-
-  if (is_chromecast) {
-    defines = [ "IS_CHROMECAST" ]
-  }
 }
 
 if (is_android) {

services/device/time_zone_monitor/time_zone_monitor_linux.cc

@@ -21,6 +21,7 @@
 #include "base/threading/scoped_blocking_call.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "third_party/icu/source/i18n/unicode/timezone.h"
 
 namespace device {
@@ -36,7 +37,7 @@ class TimeZoneMonitorLinux : public TimeZoneMonitor {
   ~TimeZoneMonitorLinux() override;
 
   void NotifyClientsFromImpl() {
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
     // On Chromecast, ICU's default time zone is already set to a new zone. No
     // need to redetect it with detectHostTimeZone() or to update ICU.
     // See http://b/112498903 and http://b/113344065.

services/network/BUILD.gn

@@ -219,6 +219,7 @@ jumbo_component("network_service") {
 
   deps = [
     "//base",
+    "//build:chromecast_buildflags",
     "//components/content_settings/core/common",
     "//components/cookie_config",
     "//components/domain_reliability",
@@ -274,10 +275,6 @@ jumbo_component("network_service") {
 
   defines = [ "IS_NETWORK_SERVICE_IMPL" ]
 
-  if (is_chromecast) {
-    defines += [ "IS_CHROMECAST" ]
-  }
-
   if (trial_comparison_cert_verifier_supported) {
     sources += [
       "trial_comparison_cert_verifier_mojo.cc",

services/network/network_context.cc

@@ -27,6 +27,7 @@
 #include "base/task/task_traits.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "components/cookie_config/cookie_store_util.h"
 #include "components/domain_reliability/monitor.h"
 #include "components/network_session_configurator/browser/network_session_configurator.h"
@@ -1756,7 +1757,7 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext(
 
     net::CookieCryptoDelegate* crypto_delegate = nullptr;
     if (params_->enable_encrypted_cookies) {
-#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && !defined(IS_CHROMECAST)
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && !BUILDFLAG(IS_CHROMECAST)
       DCHECK(network_service_->os_crypt_config_set())
           << "NetworkService::SetCryptConfig must be called before creating a "
              "NetworkContext with encrypted cookies.";

services/network/network_service.cc

@@ -21,6 +21,7 @@
 #include "base/task/post_task.h"
 #include "base/timer/timer.h"
 #include "base/values.h"
+#include "build/chromecast_buildflags.h"
 #include "components/network_session_configurator/common/network_features.h"
 #include "components/os_crypt/os_crypt.h"
 #include "mojo/core/embedder/embedder.h"
@@ -61,7 +62,7 @@
 #include "third_party/boringssl/src/include/openssl/cpu.h"
 #endif
 
-#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && !defined(IS_CHROMECAST)
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && !BUILDFLAG(IS_CHROMECAST)
 #include "components/os_crypt/key_storage_config_linux.h"
 #endif
 
@@ -615,7 +616,7 @@ void NetworkService::OnCertDBChanged() {
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
 void NetworkService::SetCryptConfig(mojom::CryptConfigPtr crypt_config) {
-#if !defined(IS_CHROMECAST)
+#if !BUILDFLAG(IS_CHROMECAST)
   DCHECK(!os_crypt_config_set_);
   auto config = std::make_unique<os_crypt::Config>();
   config->store = crypt_config->store;

services/network/public/cpp/BUILD.gn

@@ -110,10 +110,6 @@ jumbo_component("cpp") {
   ]
 
   defines = [ "IS_NETWORK_CPP_IMPL" ]
-
-  if (is_chromecast) {
-    defines += [ "IS_CHROMECAST" ]
-  }
 }
 
 jumbo_component("cpp_base") {

services/tracing/public/cpp/BUILD.gn

@@ -98,6 +98,7 @@ if (!is_nacl && !is_ios) {
     all_dependent_configs = [ "//third_party/perfetto/gn:public_config" ]
 
     deps = [
+      "//build:chromecast_buildflags",
       "//third_party/perfetto/include/perfetto/protozero",
       "//third_party/perfetto/protos/perfetto/trace/chrome:minimal_complete_lite",
     ]
@@ -111,10 +112,6 @@ if (!is_nacl && !is_ios) {
       deps += [ "//third_party/perfetto/src/tracing:ipc" ]
     }
 
-    if (is_chromecast) {
-      defines += [ "IS_CHROMECAST" ]
-    }
-
     if (is_android && can_unwind_with_cfi_table && is_official_build) {
       sources += [
         "stack_sampling/stack_sampler_android.cc",

services/tracing/public/cpp/perfetto/perfetto_config.cc

@@ -12,6 +12,7 @@
 #include "base/trace_event/trace_config.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "services/tracing/public/mojom/perfetto_service.mojom.h"
 
 namespace tracing {
@@ -102,7 +103,7 @@ perfetto::TraceConfig GetDefaultPerfettoConfig(
 // Capture system trace events if supported and enabled. The datasources will
 // only emit events if system tracing is enabled in |chrome_config|.
   if (!privacy_filtering_enabled) {
-#if defined(OS_CHROMEOS) || (defined(IS_CHROMECAST) && defined(OS_LINUX))
+#if defined(OS_CHROMEOS) || (BUILDFLAG(IS_CHROMECAST) && defined(OS_LINUX))
     AddDataSourceConfig(&perfetto_config,
                         tracing::mojom::kSystemTraceDataSourceName,
                         chrome_config_string, privacy_filtering_enabled);

services/tracing/public/cpp/tracing_features.cc

@@ -10,6 +10,7 @@
 #include "base/metrics/field_trial_params.h"
 #include "base/strings/string_number_conversions.h"
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "components/tracing/common/tracing_switches.h"
 
 #if defined(OS_ANDROID)
@@ -36,7 +37,7 @@ const base::Feature kPerfettoForceOutOfProcessProducer{
 // Runs the tracing service as an in-process browser service.
 const base::Feature kTracingServiceInProcess {
   "TracingServiceInProcess",
-#if defined(OS_ANDROID) || defined(IS_CHROMECAST)
+#if defined(OS_ANDROID) || BUILDFLAG(IS_CHROMECAST)
       base::FEATURE_ENABLED_BY_DEFAULT
 #else
       base::FEATURE_DISABLED_BY_DEFAULT

third_party/blink/renderer/modules/BUILD.gn

@@ -448,6 +448,7 @@ jumbo_source_set("unit_tests") {
   deps = [
     ":modules",
     ":modules_testing",
+    "//build:chromecast_buildflags",
     "//media:test_support",
     "//net:quic_test_tools",
     "//services/device/public/cpp:test_support",

third_party/blink/renderer/modules/mediastream/BUILD.gn

@@ -95,6 +95,7 @@ blink_modules_sources("mediastream") {
     "webmediaplayer_ms_compositor.h",
   ]
   deps = [
+    "//build:chromecast_buildflags",
     "//media/capture/mojom:image_capture_blink",
     "//media/webrtc",
   ]

third_party/blink/renderer/modules/mediastream/media_stream_audio_processor.cc

@@ -21,6 +21,7 @@
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "media/base/audio_fifo.h"
 #include "media/base/audio_parameters.h"
 #include "media/base/channel_layout.h"
@@ -531,10 +532,10 @@ void MediaStreamAudioProcessor::InitializeAudioProcessingModule(
         base::FeatureList::IsEnabled(features::kWebRtcHybridAgc);
 
     config.Set<webrtc::ExperimentalAgc>(experimental_agc);
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
   } else {
     config.Set<webrtc::ExperimentalAgc>(new webrtc::ExperimentalAgc(false));
-#endif  // defined(IS_CHROMECAST)
+#endif  // BUILDFLAG(IS_CHROMECAST)
   }
 
   // Create and configure the webrtc::AudioProcessing.
@@ -617,12 +618,12 @@ void MediaStreamAudioProcessor::InitializeCaptureFifo(
   // what format it would prefer.
   const int output_sample_rate = audio_processing_
                                      ?
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
                                      std::min(blink::kAudioProcessingSampleRate,
                                               input_format.sample_rate())
 #else
                                      blink::kAudioProcessingSampleRate
-#endif  // defined(IS_CHROMECAST)
+#endif  // BUILDFLAG(IS_CHROMECAST)
                                      : input_format.sample_rate();
 
   media::ChannelLayout output_channel_layout;

third_party/blink/renderer/modules/mediastream/media_stream_audio_processor_test.cc

@@ -17,6 +17,7 @@
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
+#include "build/chromecast_buildflags.h"
 #include "media/base/audio_bus.h"
 #include "media/base/audio_parameters.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ -241,10 +242,10 @@ TEST_F(MediaStreamAudioProcessorTest, MAYBE_TestAllSampleRates) {
     32000,
     44100,
     48000
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
     ,
     96000
-#endif  // defined(IS_CHROMECAST)
+#endif  // BUILDFLAG(IS_CHROMECAST)
   };
   for (size_t i = 0; i < base::size(kSupportedSampleRates); ++i) {
     int buffer_size = kSupportedSampleRates[i] / 100;
@@ -255,11 +256,11 @@ TEST_F(MediaStreamAudioProcessorTest, MAYBE_TestAllSampleRates) {
     VerifyDefaultComponents(audio_processor.get());
 
     int expected_sample_rate =
-#if defined(IS_CHROMECAST)
+#if BUILDFLAG(IS_CHROMECAST)
         std::min(kSupportedSampleRates[i], blink::kAudioProcessingSampleRate);
 #else
         blink::kAudioProcessingSampleRate;
-#endif  // defined(IS_CHROMECAST)
+#endif  // BUILDFLAG(IS_CHROMECAST)
     ProcessDataAndVerifyFormat(audio_processor.get(), expected_sample_rate,
                                kAudioProcessingNumberOfChannel,
                                expected_sample_rate / 100);