Commit 8a1acf41 authored by Erik Staab's avatar Erik Staab Committed by Commit Bot

Reland "GN: switch from check_targets to no_check_targets."

This reverts commit e4c2871d.

Reason for revert: Added a few more exceptions from waterfall builders.

Original change's description:
> Revert "GN: switch from check_targets to no_check_targets."
> 
> This reverts commit b9897c33.
> 
> Reason for revert: This breaks a few waterfall builders.
> 
> Original change's description:
> > GN: switch from check_targets to no_check_targets.
> > 
> > The list was semi-automatically generated by parsing the output of
> > "gn check" against various configurations.
> > 
> > With some exceptions, parsing was done using:
> >   grep -E -A1 '(The target:|It is not in)' | grep '//' | \
> >   grep -v '//build/toolchain' | cut -f1 -d: | sort | uniq -c | \
> >   sed -e 's/ *\([0-9]*\) *\(.*\)/  "\2:*",  # \1 errors/'
> > 
> > Note: if this breaks the "gn gen" step of a build configuration that
> > isn't tested in the CQ please add more entries to this .gn file instead
> > of reverting this CL.
> > 
> > Bug: 896680
> > 
> > Change-Id: I4e3d2b316ec014f969303f7c4bb809e436447b10
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278172
> > Commit-Queue: Erik Staab <estaab@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Cr-Commit-Position: refs/heads/master@{#786102}
> 
> TBR=dpranke@google.com,estaab@chromium.org
> 
> Change-Id: I994a4149f38fe00779045612291b0984b95f9075
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 896680
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286473
> Reviewed-by: Erik Staab <estaab@chromium.org>
> Commit-Queue: Erik Staab <estaab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786115}

TBR=dpranke@google.com,estaab@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 896680
Change-Id: I44f0283cde2a9e59673fd18a0e854711bca218fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287909Reviewed-by: default avatarErik Staab <estaab@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@google.com>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786405}
parent f1bc7de0
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment