Commit 8a1ddba0 authored by Eric Willigers's avatar Eric Willigers Committed by Commit Bot

ExtensionManagementApiTest cleanup

DesktopPWAsWithoutExtensions has shipped.

The test case GenerateAppForLink no longer needs to
be parameterized.

Bug: 1065748
Change-Id: I1893b45f7183ccb24c51149c7189aed62751fa5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459256
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815284}
parent 4d3b38f1
...@@ -22,8 +22,6 @@ ...@@ -22,8 +22,6 @@
#include "chrome/browser/web_applications/components/web_app_helpers.h" #include "chrome/browser/web_applications/components/web_app_helpers.h"
#include "chrome/browser/web_applications/components/web_app_provider_base.h" #include "chrome/browser/web_applications/components/web_app_provider_base.h"
#include "chrome/browser/web_applications/test/test_web_app_ui_manager.h" #include "chrome/browser/web_applications/test/test_web_app_ui_manager.h"
#include "chrome/browser/web_applications/test/web_app_test.h"
#include "chrome/common/chrome_features.h"
#include "chrome/common/chrome_switches.h" #include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h" #include "chrome/common/extensions/extension_constants.h"
#include "content/public/test/browser_test.h" #include "content/public/test/browser_test.h"
...@@ -41,7 +39,6 @@ ...@@ -41,7 +39,6 @@
using extensions::Extension; using extensions::Extension;
using extensions::Manifest; using extensions::Manifest;
using web_app::ProviderType;
namespace { namespace {
...@@ -148,38 +145,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, CreateAppShortcut) { ...@@ -148,38 +145,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, CreateAppShortcut) {
"createAppShortcut.html")); "createAppShortcut.html"));
} }
class GenerateAppManagementApiTest IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, GenerateAppForLink) {
: public ExtensionManagementApiTest,
public ::testing::WithParamInterface<ProviderType> {
public:
void SetUp() override {
if (GetParam() == ProviderType::kWebApps) {
scoped_feature_list_.InitWithFeatures(
{features::kDesktopPWAsWithoutExtensions}, {});
} else {
DCHECK_EQ(GetParam(), ProviderType::kBookmarkApps);
scoped_feature_list_.InitWithFeatures(
{}, {features::kDesktopPWAsWithoutExtensions});
}
ExtensionManagementApiTest::SetUp();
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_P(GenerateAppManagementApiTest, GenerateAppForLink) {
ASSERT_TRUE(RunExtensionSubtest("management/test", ASSERT_TRUE(RunExtensionSubtest("management/test",
"generateAppForLink.html")); "generateAppForLink.html"));
} }
INSTANTIATE_TEST_SUITE_P(All,
GenerateAppManagementApiTest,
::testing::Values(ProviderType::kBookmarkApps,
ProviderType::kWebApps),
web_app::ProviderTypeParamToString);
class InstallReplacementWebAppApiTest : public ExtensionManagementApiTest { class InstallReplacementWebAppApiTest : public ExtensionManagementApiTest {
public: public:
InstallReplacementWebAppApiTest() InstallReplacementWebAppApiTest()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment