Commit 8a42fcf5 authored by Thomas Guilbert's avatar Thomas Guilbert Committed by Commit Bot

Fix leftover |cast_impl_| comments

This CL updates oudated comments, with no production code changes.

TBR: chcunningham@
Change-Id: Ie12fb6ba08048c7ca2a14c49f0daee8636e058db
Reviewed-on: https://chromium-review.googlesource.com/c/1497175
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: default avatarThomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636924}
parent eeaff9dd
...@@ -2521,11 +2521,8 @@ void WebMediaPlayerImpl::StartPipeline() { ...@@ -2521,11 +2521,8 @@ void WebMediaPlayerImpl::StartPipeline() {
if (demuxer_found_hls_ || if (demuxer_found_hls_ ||
renderer_factory_selector_->GetCurrentFactory() renderer_factory_selector_->GetCurrentFactory()
->GetRequiredMediaResourceType() == MediaResource::Type::URL) { ->GetRequiredMediaResourceType() == MediaResource::Type::URL) {
// MediaPlayerRendererClient factory is the only factory that a // MediaPlayerRendererClientFactory is the only factory that a uses
// MediaResource::Type::URL for the moment. This might no longer be true // MediaResource::Type::URL for the moment.
// when we remove WebMediaPlayerCast.
//
// TODO(tguilbert/avayvod): Update this flag when removing |cast_impl_|.
using_media_player_renderer_ = true; using_media_player_renderer_ = true;
// MediaPlayerRenderer does not provide pipeline stats, so nuke capabilities // MediaPlayerRenderer does not provide pipeline stats, so nuke capabilities
...@@ -2767,15 +2764,6 @@ void WebMediaPlayerImpl::SetSuspendState(bool is_suspended) { ...@@ -2767,15 +2764,6 @@ void WebMediaPlayerImpl::SetSuspendState(bool is_suspended) {
} }
} }
// NOTE: |is_remote| and |is_flinging| both indicate that we are in a remote
// playback session, with the following differences:
// - |is_remote| : we are using |cast_impl_|, and most of WMPI's functions
// are forwarded to it. This method of remote playback is scheduled
// for deprecation soon, in favor of the |is_flinging| path.
// - |is_flinging| : we are using the FlingingRenderer, and WMPI should
// behave exactly if we are using the DefaultRenderer, except for the
// disabling of certain optimizations.
// See https://crbug.com/790766.
WebMediaPlayerImpl::PlayState WebMediaPlayerImpl::PlayState
WebMediaPlayerImpl::UpdatePlayState_ComputePlayState(bool is_flinging, WebMediaPlayerImpl::UpdatePlayState_ComputePlayState(bool is_flinging,
bool can_auto_suspend, bool can_auto_suspend,
......
...@@ -775,11 +775,9 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl ...@@ -775,11 +775,9 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
GURL loaded_url_; GURL loaded_url_;
// NOTE: |using_media_player_renderer_| is set based on the usage of a // NOTE: |using_media_player_renderer_| is set based on the usage of a
// MediaResource::Type::URL in StartPipeline(). This currently works because // MediaResource::Type::URL in StartPipeline(). This works because
// the MediaPlayerRendererClient factory is the only factory that returns that // MediaPlayerRendererClientFactory is the only factory that uses
// Type, but this may no longer be accurate when we remove |cast_impl_| and // MediaResource::Type::URL for now.
// WebMediaPlayerCast. This flag should be renamed/updated accordingly when
// removing |cast_impl_|.
bool using_media_player_renderer_ = false; bool using_media_player_renderer_ = false;
// Set whenever the demuxer encounters an HLS file. // Set whenever the demuxer encounters an HLS file.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment