Commit 8a434902 authored by Victor Hugo Vianna Silva's avatar Victor Hugo Vianna Silva Committed by Commit Bot

Remove custom fallback string for 'device passwords' page

Instead of using a custom string, the page should just display the same
"Saved passwords will appear here" string as chrome://settings/passwords
in case one of the subsections is empty.

Bug: None
Change-Id: I9236e544d5bc988bf6aa89c18524f4591dceeba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238054Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#776918}
parent 121353d3
......@@ -300,10 +300,6 @@
Passwords on this device
</message>
<!-- TODO(crbug.com/1062344): Make it translateable once final strings are available. Also add screenshot file. -->
<message name="IDS_SETTINGS_DEVICE_PASSWORDS_EMPTY_SUBSECTION_TEXT" translateable="false" desc="Fallback text displayed under a subsection of the 'device passwords' page, in case that subsection is empty.">
No passwords
</message>
<!-- TODO(crbug.com/1062344): Make it translateable once final strings are available. Also add screenshot file. -->
<message name="IDS_SETTINGS_DEVICE_PASSWORDS_ON_DEVICE_ONLY_HEADING" translateable="false" desc="Title of a subsection in the 'device passwords' page displaying passwords/exceptions that are stored only on the device.">
On this device only
</message>
......
......@@ -25,7 +25,7 @@
</iron-list>
<div id="noDeviceOnlyPasswordsLabel" class="list-item"
hidden$="[[isNonEmpty_(deviceOnlyPasswords_)]]">
$i18n{devicePasswordsEmptySubsectionText}
$i18n{noPasswordsFound}
</div>
<div class="list-item column-header" aria-hidden="true">
$i18n{deviceAndAccountPasswordsHeading}
......@@ -44,7 +44,7 @@
</iron-list>
<div id="noDeviceAndAccountPasswordsLabel" class="list-item"
hidden$="[[isNonEmpty_(deviceAndAccountPasswords_)]]">
$i18n{devicePasswordsEmptySubsectionText}
$i18n{noPasswordsFound}
</div>
</div>
</passwords-list-handler>
......
......@@ -900,8 +900,6 @@ void AddAutofillStrings(content::WebUIDataSource* html_source,
{"editPasswordPasswordLabel", IDS_SETTINGS_PASSWORDS_PASSWORD},
{"noAddressesFound", IDS_SETTINGS_ADDRESS_NONE},
{"noPasswordsFound", IDS_SETTINGS_PASSWORDS_NONE},
{"devicePasswordsEmptySubsectionText",
IDS_SETTINGS_DEVICE_PASSWORDS_EMPTY_SUBSECTION_TEXT},
{"noExceptionsFound", IDS_SETTINGS_PASSWORDS_EXCEPTIONS_NONE},
{"import", IDS_PASSWORD_MANAGER_IMPORT_BUTTON},
{"exportMenuItem", IDS_SETTINGS_PASSWORDS_EXPORT_MENU_ITEM},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment