Commit 8a5629f0 authored by ajith.v's avatar ajith.v Committed by Commit bot

Making Android Url bar behavior to ESCAPE key same as in Desktop Chrome

In response to ESCAPE key desktop chrome is selecting all the contents
of Url bar. Making same behavior in Android Chrome as well.

BUG=631075

Review-Url: https://codereview.chromium.org/2211433002
Cr-Commit-Position: refs/heads/master@{#416452}
parent a73f1b21
......@@ -72,8 +72,9 @@ public class KeyboardShortcuts {
return true;
case KeyEvent.KEYCODE_ESCAPE:
if (event.getAction() == KeyEvent.ACTION_DOWN && event.getRepeatCount() == 0) {
return activity.exitFullscreenIfShowing();
if (activity.exitFullscreenIfShowing()) return true;
}
break;
case KeyEvent.KEYCODE_TV:
case KeyEvent.KEYCODE_GUIDE:
case KeyEvent.KEYCODE_DVR:
......
......@@ -333,6 +333,11 @@ public class LocationBarLayout extends FrameLayout implements OnClickListener,
return true;
}
}
} else if (keyCode == KeyEvent.KEYCODE_ESCAPE) {
if (event.getAction() == KeyEvent.ACTION_DOWN && event.getRepeatCount() == 0) {
revertChanges();
return true;
}
}
return false;
}
......@@ -899,11 +904,14 @@ public class LocationBarLayout extends FrameLayout implements OnClickListener,
} else {
Tab tab = mToolbarDataProvider.getTab();
if (NativePageFactory.isNativePageUrl(tab.getUrl(), tab.isIncognito())) {
mUrlBar.setUrl("", null);
setUrlBarText("", null);
} else {
mUrlBar.setUrl(
setUrlBarText(
mToolbarDataProvider.getText(), getCurrentTabUrl());
selectAll();
}
hideSuggestions();
UiUtils.hideKeyboard(mUrlBar);
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment