Remove need for CaptivePortalBlockingPage custom subclasses
To componentize CaptivePortalBlockingPage, we are going to move the Chrome-specific elements of its creation into ChromeSecurityBlockingPageFactory. However, that move is currently hindered by the fact that there are two subclasses of CaptivePortalBlockingPage that supply the Wifi info for testing/debugging purposes. This CL eliminates the need for those custom subclasses by instead adding a method to CaptivePortalBlockingPage to override the wifi info for testing. This change will enable the transfer of all //chrome-level creation sites of CaptivePortalBlockingPage to do so via ChromeSecurityBlockingPageFactory in a followup CL. Bug: 1025059 Change-Id: I9b6feaddcb52ee994ecae8dc3ba73c51878d48fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949469 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#721926}
Showing
Please register or sign in to comment